Final cleanup

This commit is contained in:
tbuckinx 2023-11-23 22:50:12 +01:00
parent afc32f86f7
commit 0102736d4c
7 changed files with 14 additions and 25 deletions

View File

@ -1,7 +1,6 @@
package com.gildedrose; package com.gildedrose;
import com.gildedrose.domain.*; import com.gildedrose.domain.*;
import com.gildedrose.domain.InventoryItem;
import static java.util.stream.Stream.of; import static java.util.stream.Stream.of;

View File

@ -12,8 +12,7 @@ public class AgedBrie extends InventoryItem {
@Override @Override
public int handleQuality() { public int handleQuality() {
quality = increaseQualityBelowMaximum(); return increaseQualityBelowMaximum();
return quality;
} }
@Override @Override
@ -23,7 +22,6 @@ public class AgedBrie extends InventoryItem {
@Override @Override
public int handleQualityAfterSellIn() { public int handleQualityAfterSellIn() {
quality = increaseQualityBelowMaximum(); return increaseQualityBelowMaximum();
return quality;
} }
} }

View File

@ -12,8 +12,7 @@ public class BackstagePass extends InventoryItem {
@Override @Override
public int handleQuality() { public int handleQuality() {
quality = increaseQualityBelowMaximum(); return increaseQualityBelowMaximum();
return quality;
} }
@Override @Override
@ -23,31 +22,29 @@ public class BackstagePass extends InventoryItem {
@Override @Override
public int handleQualityAfterSellIn() { public int handleQualityAfterSellIn() {
quality = 0; return 0;
return quality;
} }
@Override @Override
public int increaseQualityBelowMaximum() { public int increaseQualityBelowMaximum() {
quality = increaseQualityIfNotMaximum(); increaseQualityIfNotMaximum();
// increase backstage pass further when sellIn date approaches // increase backstage pass further when sellIn date approaches
quality = increaseBackstagePass(); return increaseBackstagePass();
return quality;
} }
private int increaseBackstagePass() { private int increaseBackstagePass() {
if (sellIn < 10) { if (sellIn < 10) {
quality = increaseQualityIfNotMaximum(); increaseQualityIfNotMaximum();
if (sellIn < 5) { if (sellIn < 5) {
quality = increaseQualityIfNotMaximum(); increaseQualityIfNotMaximum();
} }
} }
return quality; return quality;
} }
private int increaseQualityIfNotMaximum() { private void increaseQualityIfNotMaximum() {
return super.increaseQualityBelowMaximum(); quality = super.increaseQualityBelowMaximum();
} }
} }

View File

@ -17,7 +17,6 @@ public class ConjuredItem extends InventoryItem {
@Override @Override
public int handleQualityAfterSellIn() { public int handleQualityAfterSellIn() {
quality = decreaseQualityAboveZero(); return decreaseQualityAboveZero();
return quality;
} }
} }

View File

@ -17,7 +17,6 @@ public class DefaultItem extends InventoryItem {
@Override @Override
public int handleQualityAfterSellIn() { public int handleQualityAfterSellIn() {
quality = decreaseQualityAboveZero(); return decreaseQualityAboveZero();
return quality;
} }
} }

View File

@ -19,8 +19,7 @@ public abstract class InventoryItem {
public abstract int handleQualityAfterSellIn(); public abstract int handleQualityAfterSellIn();
public int decreaseQualityAboveZero() { public int decreaseQualityAboveZero() {
quality = quality > 0 ? quality - 1 : 0; return quality > 0 ? quality - 1 : 0;
return quality;
} }
public int increaseQualityBelowMaximum() { public int increaseQualityBelowMaximum() {
@ -31,8 +30,7 @@ public abstract class InventoryItem {
} }
public int reduceSellIn() { public int reduceSellIn() {
sellIn--; return --sellIn;
return sellIn;
} }
public int handleQuality() { public int handleQuality() {

View File

@ -5,7 +5,6 @@ import com.gildedrose.Item;
public class Legendary extends InventoryItem { public class Legendary extends InventoryItem {
public Legendary(Item item) { public Legendary(Item item) {
super();
setName(item.name); setName(item.name);
setSellIn(item.sellIn); setSellIn(item.sellIn);
setQuality(item.quality); setQuality(item.quality);