mirror of
https://github.com/emilybache/GildedRose-Refactoring-Kata.git
synced 2026-02-11 04:31:21 +00:00
<duplicate code> verificar si item tiene calidad antes de decrementar
This commit is contained in:
parent
06120b080d
commit
010640d93c
@ -14,6 +14,7 @@ class GildedRose
|
|||||||
|
|
||||||
def decrease_quality(item)
|
def decrease_quality(item)
|
||||||
return if legendary?(item)
|
return if legendary?(item)
|
||||||
|
return if item.quality <= 0
|
||||||
|
|
||||||
item.quality = item.quality - 1
|
item.quality = item.quality - 1
|
||||||
end
|
end
|
||||||
@ -28,9 +29,7 @@ class GildedRose
|
|||||||
|
|
||||||
def update_item_quality(item)
|
def update_item_quality(item)
|
||||||
if !aged_brie?(item) and !backstage_pass?(item)
|
if !aged_brie?(item) and !backstage_pass?(item)
|
||||||
if item.quality > 0
|
decrease_quality(item)
|
||||||
decrease_quality(item)
|
|
||||||
end
|
|
||||||
else
|
else
|
||||||
if item.quality < 50
|
if item.quality < 50
|
||||||
increase_quality(item)
|
increase_quality(item)
|
||||||
@ -55,9 +54,7 @@ class GildedRose
|
|||||||
def update_days_passed(item)
|
def update_days_passed(item)
|
||||||
if !aged_brie?(item)
|
if !aged_brie?(item)
|
||||||
if !backstage_pass?(item)
|
if !backstage_pass?(item)
|
||||||
if item.quality > 0
|
decrease_quality(item)
|
||||||
decrease_quality(item)
|
|
||||||
end
|
|
||||||
else
|
else
|
||||||
item.quality = item.quality - item.quality
|
item.quality = item.quality - item.quality
|
||||||
end
|
end
|
||||||
|
|||||||
Loading…
Reference in New Issue
Block a user