From 022eded43037e6a54e4ba89f4469b4bf3b18a36e Mon Sep 17 00:00:00 2001 From: Gayun00 Date: Mon, 25 Sep 2023 18:37:10 +0900 Subject: [PATCH] Refactor: remove unnecessary conditional depth --- TypeScript/app/gilded-rose.ts | 20 +++++++------------- 1 file changed, 7 insertions(+), 13 deletions(-) diff --git a/TypeScript/app/gilded-rose.ts b/TypeScript/app/gilded-rose.ts index 8bbc3a96..15d316bf 100644 --- a/TypeScript/app/gilded-rose.ts +++ b/TypeScript/app/gilded-rose.ts @@ -10,11 +10,6 @@ export class Item { this.sellIn = sellIn; this.quality = quality; } - - // handleSellIn() { - // if (this.name === ITEMS.SURFRAS) return; - // this.sellIn--; - // } } export class GildedRose { @@ -25,14 +20,13 @@ export class GildedRose { } handlePassesQuality(item) { - if (item.name == ITEMS.PASSES) { - if (6 <= item.sellIn && item.sellIn < 11) { - item.quality += 1; - } + if (item.name !== ITEMS.PASSES) return; + if (6 <= item.sellIn && item.sellIn < 11) { + item.quality += 1; + } - if (item.sellIn < 6) { - item.quality += 2; - } + if (item.sellIn < 6) { + item.quality += 2; } } @@ -45,7 +39,7 @@ export class GildedRose { item.quality = item.quality + 1; break; case ITEMS.SURFRAS: - item.quality = item.quality - item.quality; + item.quality = 0; break; default: if (!item.quality) return;