Update

- Added a Readme.md file
- Separated Unit Tests from main project
- Checked to ensure

csharp/ApprovalTest.cs

@@ -1,28 +1,28 @@
-using System;
-using System.IO;
-using System.Text;
-using ApprovalTests;
-using ApprovalTests.Reporters;
-using NUnit.Framework;
+//using System;
+//using System.IO;
+//using System.Text;
+//using ApprovalTests;
+//using ApprovalTests.Reporters;
+//using NUnit.Framework;
 
-namespace csharp
-{
-    [UseReporter(typeof(DiffReporter))]
-    [TestFixture]
-    public class ApprovalTest
-    {
-        [Test]
-        public void ThirtyDays()
-        {
+//namespace csharp
+//{
+//    [UseReporter(typeof(DiffReporter))]
+//    [TestFixture]
+//    public class ApprovalTest
+//    {
+//        [Test]
+//        public void ThirtyDays()
+//        {
             
-            StringBuilder fakeoutput = new StringBuilder();
-            Console.SetOut(new StringWriter(fakeoutput));
-            Console.SetIn(new StringReader("a\n"));
+//            StringBuilder fakeoutput = new StringBuilder();
+//            Console.SetOut(new StringWriter(fakeoutput));
+//            Console.SetIn(new StringReader("a\n"));
 
-            Program.Main(new string[] { });
-            var output = fakeoutput.ToString();
+//            Program.Main(new string[] { });
+//            var output = fakeoutput.ToString();
 
-            Approvals.Verify(output);
-        }
-    }
-}
+//            Approvals.Verify(output);
+//        }
+//    }
+//}

csharp/GildedRoseTest.cs

@@ -1,18 +1,18 @@
-using NUnit.Framework;
-using System.Collections.Generic;
+//using NUnit.Framework;
+//using System.Collections.Generic;
 
-namespace csharp
-{
-    [TestFixture]
-    public class GildedRoseTest
-    {
-        [Test]
-        public void foo()
-        {
-            IList<Item> Items = new List<Item> { new Item { Name = "foo", SellIn = 0, Quality = 0 } };
-            GildedRose app = new GildedRose(Items);
-            app.UpdateQuality();
-            Assert.AreEqual("fixme", Items[0].Name);
-        }
-    }
-}
+//namespace csharp
+//{
+//    [TestFixture]
+//    public class GildedRoseTest
+//    {
+//        [Test]
+//        public void foo()
+//        {
+//            IList<Item> Items = new List<Item> { new Item { Name = "foo", SellIn = 0, Quality = 0 } };
+//            GildedRose app = new GildedRose(Items);
+//            app.UpdateQuality();
+//            Assert.AreEqual("fixme", Items[0].Name);
+//        }
+//    }
+//}

csharp/Program.cs

@@ -7,7 +7,7 @@ namespace csharp
     {
         public static void Main(string[] args)
         {
-            Console.WriteLine("OMGHAI!");
+            //Console.WriteLine("OMGHAI!");
 
             IList<Item> Items = new List<Item>{
                 new Item {Name = "+5 Dexterity Vest", SellIn = 10, Quality = 20},
@@ -50,6 +50,7 @@ namespace csharp
                 }
                 Console.WriteLine("");
                 app.UpdateQuality();
+                Console.Read();
             }
         }
     }

csharp/ReadMe.md

@@ -0,0 +1,31 @@
+# Gilded Rose Refactoring Kata
+
+Introduction:
+I will try as much as I can to write my thought processes here as it's one of the requirements. 
+I will just write the relevant parts and not my whole thoughts. That would be weird since I was thinking of lunch just before I started. :D
+
+
+SIDE COMMENTS:
+- I can't exactly do a full TDD since the application is already written. TDD requires tests before development but this is a refactoring.
+- One of the things I would ideally change if it was not explicitly said to not to is the fact that it uses strings to check. that can be really erroneous. 
+  If I had my way, I would include IDs of some sort.
+
+1:
+One of the first things I want to do is just get the program to run. so am not fixing anything except what will make the program run.
+- The program seems to run fine. except I could not see the results so added a little line to see what was printed. over than that. it looks good. 
+  Makes sense why they kept using it. It works! :/
+
+2:
+After this I want to include some Unit tests to ensure all parts are working as they should. This may require some fixing. Not sure.
+- First thing I did was separate the tests from the main application. I do not want to have the possibility of a memory leak or bulky apps
+- Original unit tests were written in NUnit and I chose to use MSTest. Why? no reason! Just a choice.
+- First Unit Test returned 3 errors. 
+Test	Duration	Traits	Error Message
+UpdateQualityTestForAgedBrie_SellDateIsLessThan5_IncreaseQualityByThree Failed	1 sec		Assert.AreEqual failed. Expected:<3>. Actual:<1>. 
+UpdateQualityTestForAgedBrie_SellDateIsLessThan10ButGreaterThan5_IncreaseQualityByTwo Failed	2 sec		Assert.AreEqual failed. Expected:<2>. Actual:<1>. 
+UpdateQualityTestForAgedBrie_AfterConcert_DropToZero Failed	12.7 sec		Assert.AreEqual failed. Expected:<0>. Actual:<12>. 
+
+At least we now know what to work on :facepalm
+
+3:
+Then when all tests are good. I can start working with an aim of not breaking any tests.

csharp/csharp.sln

@@ -1,10 +1,12 @@
 
 Microsoft Visual Studio Solution File, Format Version 12.00
-# Visual Studio 14
-VisualStudioVersion = 14.0.25420.1
+# Visual Studio Version 16
+VisualStudioVersion = 16.0.30804.86
 MinimumVisualStudioVersion = 10.0.40219.1
 Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "csharp", "csharp.csproj", "{176C0214-9136-4079-8DAB-11D7420C3881}"
 EndProject
+Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "csharpUnitTests", "..\csharpTests\csharpUnitTests.csproj", "{4CA6C3A0-B59A-4EC3-AE4A-4F85100563C8}"
+EndProject
 Global
 	GlobalSection(SolutionConfigurationPlatforms) = preSolution
 		Debug|Any CPU = Debug|Any CPU
@@ -15,8 +17,15 @@ Global
 		{176C0214-9136-4079-8DAB-11D7420C3881}.Debug|Any CPU.Build.0 = Debug|Any CPU
 		{176C0214-9136-4079-8DAB-11D7420C3881}.Release|Any CPU.ActiveCfg = Release|Any CPU
 		{176C0214-9136-4079-8DAB-11D7420C3881}.Release|Any CPU.Build.0 = Release|Any CPU
+		{4CA6C3A0-B59A-4EC3-AE4A-4F85100563C8}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
+		{4CA6C3A0-B59A-4EC3-AE4A-4F85100563C8}.Debug|Any CPU.Build.0 = Debug|Any CPU
+		{4CA6C3A0-B59A-4EC3-AE4A-4F85100563C8}.Release|Any CPU.ActiveCfg = Release|Any CPU
+		{4CA6C3A0-B59A-4EC3-AE4A-4F85100563C8}.Release|Any CPU.Build.0 = Release|Any CPU
 	EndGlobalSection
 	GlobalSection(SolutionProperties) = preSolution
 		HideSolutionNode = FALSE
 	EndGlobalSection
+	GlobalSection(ExtensibilityGlobals) = postSolution
+		SolutionGuid = {543CC0C1-1FB8-452A-9DA4-E85F26F9E349}
+	EndGlobalSection
 EndGlobal

csharpTests/GildedRoseTests.cs

@@ -0,0 +1,125 @@
+using Microsoft.VisualStudio.TestTools.UnitTesting;
+using csharp;
+using System;
+using System.Collections.Generic;
+using System.Linq;
+using System.Text;
+using System.Threading.Tasks;
+
+namespace csharp.Tests
+{
+    [TestClass()]
+    public class GildedRoseTests
+    {
+
+        [TestMethod()]
+        public void DefaultTest() // Test that came with app
+        {
+            IList<Item> Items = new List<Item> { new Item { Name = "Aged Brie", SellIn = 0, Quality = 0 } };
+            GildedRose app = new GildedRose(Items);
+
+            app.UpdateQuality();
+
+            Assert.AreEqual("Aged Brie", Items[0].Name);
+        }
+
+        [TestMethod()]
+        public void UpdateQualityTestForAgedBrie_SellDateIsLessThan10ButGreaterThan5_IncreaseQualityByTwo()
+        {
+            IList<Item> Items = new List<Item> { new Item { Name = "Aged Brie", SellIn = 10, Quality = 0 } };
+            GildedRose app = new GildedRose(Items);
+
+            app.UpdateQuality();
+
+            Assert.AreEqual(2, Items[0].Quality);
+        }
+
+        [TestMethod()]
+        public void UpdateQualityTestForAgedBrie_SellDateIsLessThan5_IncreaseQualityByThree()
+        {
+            IList<Item> Items = new List<Item> { new Item { Name = "Aged Brie", SellIn = 5, Quality = 0 } };
+            GildedRose app = new GildedRose(Items);
+
+            app.UpdateQuality();
+
+            Assert.AreEqual(3, Items[0].Quality);
+        }
+
+        [TestMethod()]
+        public void UpdateQualityTestForAgedBrie_AfterConcert_DropToZero()
+        {
+            IList<Item> Items = new List<Item> { new Item { Name = "Aged Brie", SellIn = 0, Quality = 10 } };
+            GildedRose app = new GildedRose(Items);
+
+            app.UpdateQuality();
+
+            Assert.AreEqual(0, Items[0].Quality);
+        }
+
+        [TestMethod()]
+        public void UpdateQualityTest_SellDatePassed_DecreaseQualityTwice()
+        {
+            IList<Item> Items = new List<Item> { new Item { Name = "Backstage passes to a TAFKAL80ETC concert", SellIn = 0, Quality = 2 } };
+            GildedRose app = new GildedRose(Items);
+
+            app.UpdateQuality();
+
+            Assert.AreEqual(0, Items[0].Quality);
+        }
+
+        [TestMethod()]
+        public void UpdateQualityTest_QualityOfItemIsNeverNegative_MinimumValue0()
+        {
+            IList<Item> Items = new List<Item> { new Item { Name = "+5 Dexterity Vest", SellIn = 0, Quality = 0 } };
+            GildedRose app = new GildedRose(Items);
+
+            app.UpdateQuality();
+
+            Assert.AreEqual(0, Items[0].Quality);
+        }
+
+        [TestMethod()]
+        public void UpdateQualityTest_QualityOfItemNeverAboveDefinedValue_MaximumValue50()
+        {
+            IList<Item> Items = new List<Item> { new Item { Name = "Aged Brie", SellIn = 1, Quality = 49 } };
+            GildedRose app = new GildedRose(Items);
+
+            app.UpdateQuality();
+
+            Assert.AreEqual(50, Items[0].Quality);
+        }
+
+        [TestMethod()]
+        public void UpdateQualityTest_LegendaryItems_NeverAltar()
+        {
+            IList<Item> Items = new List<Item> { new Item { Name = "Sulfuras, Hand of Ragnaros", SellIn = 0, Quality = 80 } };
+            GildedRose app = new GildedRose(Items);
+
+            app.UpdateQuality();
+
+            Assert.AreEqual(80, Items[0].Quality);
+        }
+
+        [TestMethod()]
+        public void UpdateQualityTest_LegendaryItems_MaximumValue80()
+        {
+            IList<Item> Items = new List<Item> { new Item { Name = "Sulfuras, Hand of Ragnaros", SellIn = 1, Quality = 80 } };
+            GildedRose app = new GildedRose(Items);
+
+            app.UpdateQuality();
+
+            Assert.AreEqual(80, Items[0].Quality);
+        }
+
+        [TestMethod()]
+        public void UpdateQualityTest_ReduceSellIn_By1Daily()
+        {
+            IList<Item> Items = new List<Item> { new Item { Name = "Aged Brie", SellIn = 1, Quality = 30 } };
+            GildedRose app = new GildedRose(Items);
+
+            app.UpdateQuality();
+
+            Assert.AreEqual(0, Items[0].SellIn);
+        }
+    }
+}

csharpTests/Properties/AssemblyInfo.cs

@@ -0,0 +1,36 @@
+using System.Reflection;
+using System.Runtime.CompilerServices;
+using System.Runtime.InteropServices;
+
+// General Information about an assembly is controlled through the following 
+// set of attributes. Change these attribute values to modify the information
+// associated with an assembly.
+[assembly: AssemblyTitle("csharpTests")]
+[assembly: AssemblyDescription("")]
+[assembly: AssemblyConfiguration("")]
+[assembly: AssemblyCompany("")]
+[assembly: AssemblyProduct("csharpTests")]
+[assembly: AssemblyCopyright("Copyright ©  2021")]
+[assembly: AssemblyTrademark("")]
+[assembly: AssemblyCulture("")]
+
+// Setting ComVisible to false makes the types in this assembly not visible 
+// to COM components.  If you need to access a type in this assembly from 
+// COM, set the ComVisible attribute to true on that type.
+[assembly: ComVisible(false)]
+
+// The following GUID is for the ID of the typelib if this project is exposed to COM
+[assembly: Guid("4ca6c3a0-b59a-4ec3-ae4a-4f85100563c8")]
+
+// Version information for an assembly consists of the following four values:
+//
+//      Major Version
+//      Minor Version 
+//      Build Number
+//      Revision
+//
+// You can specify all the values or you can default the Build and Revision Numbers 
+// by using the '*' as shown below:
+// [assembly: AssemblyVersion("1.0.*")]
+[assembly: AssemblyVersion("1.0.0.0")]
+[assembly: AssemblyFileVersion("1.0.0.0")]

csharpTests/csharpUnitTests.csproj

@@ -0,0 +1,106 @@
+<?xml version="1.0" encoding="utf-8"?>
+<Project ToolsVersion="15.0" DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
+  <Import Project="..\csharp\packages\MSTest.TestAdapter.2.1.1\build\net45\MSTest.TestAdapter.props" Condition="Exists('..\csharp\packages\MSTest.TestAdapter.2.1.1\build\net45\MSTest.TestAdapter.props')" />
+  <PropertyGroup>
+    <Configuration Condition=" '$(Configuration)' == '' ">Debug</Configuration>
+    <Platform Condition=" '$(Platform)' == '' ">AnyCPU</Platform>
+    <ProjectGuid>{4CA6C3A0-B59A-4EC3-AE4A-4F85100563C8}</ProjectGuid>
+    <OutputType>Library</OutputType>
+    <AppDesignerFolder>Properties</AppDesignerFolder>
+    <RootNamespace>csharpTests</RootNamespace>
+    <AssemblyName>csharpTests</AssemblyName>
+    <TargetFrameworkVersion>v4.5.2</TargetFrameworkVersion>
+    <FileAlignment>512</FileAlignment>
+    <ProjectTypeGuids>{3AC096D0-A1C2-E12C-1390-A8335801FDAB};{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}</ProjectTypeGuids>
+    <VisualStudioVersion Condition="'$(VisualStudioVersion)' == ''">10.0</VisualStudioVersion>
+    <VSToolsPath Condition="'$(VSToolsPath)' == ''">$(MSBuildExtensionsPath32)\Microsoft\VisualStudio\v$(VisualStudioVersion)</VSToolsPath>
+    <ReferencePath>$(ProgramFiles)\Common Files\microsoft shared\VSTT\$(VisualStudioVersion)\UITestExtensionPackages</ReferencePath>
+    <IsCodedUITest>False</IsCodedUITest>
+    <TestProjectType>UnitTest</TestProjectType>
+    <TargetFrameworkProfile />
+    <NuGetPackageImportStamp>
+    </NuGetPackageImportStamp>
+  </PropertyGroup>
+  <PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Debug|AnyCPU' ">
+    <DebugSymbols>true</DebugSymbols>
+    <DebugType>full</DebugType>
+    <Optimize>false</Optimize>
+    <OutputPath>bin\Debug\</OutputPath>
+    <DefineConstants>DEBUG;TRACE</DefineConstants>
+    <ErrorReport>prompt</ErrorReport>
+    <WarningLevel>4</WarningLevel>
+  </PropertyGroup>
+  <PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Release|AnyCPU' ">
+    <DebugType>pdbonly</DebugType>
+    <Optimize>true</Optimize>
+    <OutputPath>bin\Release\</OutputPath>
+    <DefineConstants>TRACE</DefineConstants>
+    <ErrorReport>prompt</ErrorReport>
+    <WarningLevel>4</WarningLevel>
+  </PropertyGroup>
+  <ItemGroup>
+    <Reference Include="Microsoft.VisualStudio.TestPlatform.TestFramework, Version=14.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a, processorArchitecture=MSIL">
+      <HintPath>..\csharp\packages\MSTest.TestFramework.2.1.1\lib\net45\Microsoft.VisualStudio.TestPlatform.TestFramework.dll</HintPath>
+    </Reference>
+    <Reference Include="Microsoft.VisualStudio.TestPlatform.TestFramework.Extensions, Version=14.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a, processorArchitecture=MSIL">
+      <HintPath>..\csharp\packages\MSTest.TestFramework.2.1.1\lib\net45\Microsoft.VisualStudio.TestPlatform.TestFramework.Extensions.dll</HintPath>
+    </Reference>
+    <Reference Include="System" />
+  </ItemGroup>
+  <Choose>
+    <When Condition="('$(VisualStudioVersion)' == '10.0' or '$(VisualStudioVersion)' == '') and '$(TargetFrameworkVersion)' == 'v3.5'">
+      <ItemGroup>
+        <Reference Include="Microsoft.VisualStudio.QualityTools.UnitTestFramework, Version=10.1.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a, processorArchitecture=MSIL" />
+      </ItemGroup>
+    </When>
+    <Otherwise />
+  </Choose>
+  <ItemGroup>
+    <Compile Include="GildedRoseTests.cs" />
+    <Compile Include="Properties\AssemblyInfo.cs" />
+  </ItemGroup>
+  <ItemGroup>
+    <None Include="packages.config" />
+  </ItemGroup>
+  <ItemGroup>
+    <ProjectReference Include="..\csharp\csharp.csproj">
+      <Project>{176C0214-9136-4079-8DAB-11D7420C3881}</Project>
+      <Name>csharp</Name>
+    </ProjectReference>
+  </ItemGroup>
+  <Choose>
+    <When Condition="'$(VisualStudioVersion)' == '10.0' And '$(IsCodedUITest)' == 'True'">
+      <ItemGroup>
+        <Reference Include="Microsoft.VisualStudio.QualityTools.CodedUITestFramework, Version=10.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a, processorArchitecture=MSIL">
+          <Private>False</Private>
+        </Reference>
+        <Reference Include="Microsoft.VisualStudio.TestTools.UITest.Common, Version=10.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a, processorArchitecture=MSIL">
+          <Private>False</Private>
+        </Reference>
+        <Reference Include="Microsoft.VisualStudio.TestTools.UITest.Extension, Version=10.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a, processorArchitecture=MSIL">
+          <Private>False</Private>
+        </Reference>
+        <Reference Include="Microsoft.VisualStudio.TestTools.UITesting, Version=10.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a, processorArchitecture=MSIL">
+          <Private>False</Private>
+        </Reference>
+      </ItemGroup>
+    </When>
+  </Choose>
+  <Import Project="$(VSToolsPath)\TeamTest\Microsoft.TestTools.targets" Condition="Exists('$(VSToolsPath)\TeamTest\Microsoft.TestTools.targets')" />
+  <Import Project="$(MSBuildToolsPath)\Microsoft.CSharp.targets" />
+  <Target Name="EnsureNuGetPackageBuildImports" BeforeTargets="PrepareForBuild">
+    <PropertyGroup>
+      <ErrorText>This project references NuGet package(s) that are missing on this computer. Use NuGet Package Restore to download them.  For more information, see http://go.microsoft.com/fwlink/?LinkID=322105. The missing file is {0}.</ErrorText>
+    </PropertyGroup>
+    <Error Condition="!Exists('..\csharp\packages\MSTest.TestAdapter.2.1.1\build\net45\MSTest.TestAdapter.props')" Text="$([System.String]::Format('$(ErrorText)', '..\csharp\packages\MSTest.TestAdapter.2.1.1\build\net45\MSTest.TestAdapter.props'))" />
+    <Error Condition="!Exists('..\csharp\packages\MSTest.TestAdapter.2.1.1\build\net45\MSTest.TestAdapter.targets')" Text="$([System.String]::Format('$(ErrorText)', '..\csharp\packages\MSTest.TestAdapter.2.1.1\build\net45\MSTest.TestAdapter.targets'))" />
+  </Target>
+  <Import Project="..\csharp\packages\MSTest.TestAdapter.2.1.1\build\net45\MSTest.TestAdapter.targets" Condition="Exists('..\csharp\packages\MSTest.TestAdapter.2.1.1\build\net45\MSTest.TestAdapter.targets')" />
+  <!-- To modify your build process, add your task inside one of the targets below and uncomment it. 
+       Other similar extension points exist, see Microsoft.Common.targets.
+  <Target Name="BeforeBuild">
+  </Target>
+  <Target Name="AfterBuild">
+  </Target>
+  -->
+</Project>

csharpTests/packages.config

@@ -0,0 +1,5 @@
+<?xml version="1.0" encoding="utf-8"?>
+<packages>
+  <package id="MSTest.TestAdapter" version="2.1.1" targetFramework="net452" />
+  <package id="MSTest.TestFramework" version="2.1.1" targetFramework="net452" />
+</packages>