diff --git a/Java/src/main/java/com/gildedrose/GildedRose.java b/Java/src/main/java/com/gildedrose/GildedRose.java index 6d2efca2..7283bdd2 100644 --- a/Java/src/main/java/com/gildedrose/GildedRose.java +++ b/Java/src/main/java/com/gildedrose/GildedRose.java @@ -2,6 +2,10 @@ package com.gildedrose; class GildedRose { + public static final String AGED_BRIE = "Aged Brie"; + public static final String SULFURAS = "Sulfuras, Hand of Ragnaros"; + public static final String BACKSTAGE = "Backstage passes to a TAFKAL80ETC concert"; + private Item[] items; public GildedRose(Item... items) { @@ -9,62 +13,57 @@ class GildedRose { } public void updateQuality() { - for (Item item : items) { - updateItemQuality(item); - } - } - - private void updateItemQuality(Item item) { - if (!item.name.equals("Aged Brie") - && !item.name.equals("Backstage passes to a TAFKAL80ETC concert")) { - if (item.quality > 0) { - if (!item.name.equals("Sulfuras, Hand of Ragnaros")) { - item.quality = item.quality - 1; + for (int i = 0; i < items.length; i++) { + if (!items[i].name.equals(AGED_BRIE) + && !items[i].name.equals(BACKSTAGE)) { + if (items[i].quality > 0) { + if (!items[i].name.equals(SULFURAS)) { + items[i].quality = items[i].quality - 1; } } } else { - if (item.quality < 50) { - item.quality = item.quality + 1; + if (items[i].quality < 50) { + items[i].quality = items[i].quality + 1; - if (item.name.equals("Backstage passes to a TAFKAL80ETC concert")) { - if (item.sellIn < 11) { - if (item.quality < 50) { - item.quality = item.quality + 1; + if (items[i].name.equals(BACKSTAGE)) { + if (items[i].sellIn < 11) { + if (items[i].quality < 50) { + items[i].quality = items[i].quality + 1; } } - if (item.sellIn < 6) { - if (item.quality < 50) { - item.quality = item.quality + 1; + if (items[i].sellIn < 6) { + if (items[i].quality < 50) { + items[i].quality = items[i].quality + 1; } } } } } - if (!item.name.equals("Sulfuras, Hand of Ragnaros")) { - item.sellIn = item.sellIn - 1; + if (!items[i].name.equals(SULFURAS)) { + items[i].sellIn = items[i].sellIn - 1; } - if (item.sellIn < 0) { - if (!item.name.equals("Aged Brie")) { - if (!item.name.equals("Backstage passes to a TAFKAL80ETC concert")) { - if (item.quality > 0) { - if (!item.name.equals("Sulfuras, Hand of Ragnaros")) { - item.quality = item.quality - 1; + if (items[i].sellIn < 0) { + if (!items[i].name.equals(AGED_BRIE)) { + if (!items[i].name.equals(BACKSTAGE)) { + if (items[i].quality > 0) { + if (!items[i].name.equals(SULFURAS)) { + items[i].quality = items[i].quality - 1; } } } else { - item.quality = item.quality - item.quality; + items[i].quality = items[i].quality - items[i].quality; } } else { - if (item.quality < 50) { - item.quality = item.quality + 1; + if (items[i].quality < 50) { + items[i].quality = items[i].quality + 1; } } } } - + } public Item[] getItems() { return items;