From 035e6463265a270aa8ede7a9f77be11bfebe2528 Mon Sep 17 00:00:00 2001 From: pierre Date: Sun, 19 Feb 2023 13:16:32 +0100 Subject: [PATCH] refactor: moving up the gaurd clause for quality < 50 --- Java/src/main/java/com/gildedrose/GildedRose.java | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/Java/src/main/java/com/gildedrose/GildedRose.java b/Java/src/main/java/com/gildedrose/GildedRose.java index 2c0f88db..4d9966d8 100644 --- a/Java/src/main/java/com/gildedrose/GildedRose.java +++ b/Java/src/main/java/com/gildedrose/GildedRose.java @@ -24,17 +24,12 @@ class GildedRose { if (items[i].quality < 50) { items[i].quality = items[i].quality + 1; - if (items[i].name.equals("Backstage passes to a TAFKAL80ETC concert")) { + if (items[i].name.equals("Backstage passes to a TAFKAL80ETC concert") && (items[i].quality < 50)) { if (items[i].sellIn < 11) { - if (items[i].quality < 50) { items[i].quality = items[i].quality + 1; - } } - if (items[i].sellIn < 6) { - if (items[i].quality < 50) { items[i].quality = items[i].quality + 1; - } } } }