OpenSource/GildedRose-Refactoring-Kata
1
0
Fork 0
mirror of https://github.com/emilybache/GildedRose-Refactoring-Kata.git synced 2026-02-18 16:01:42 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Test cases for "Conjured" items and code refactored

Browse Source
This commit is contained in:
geerishakadam 2021-11-29 10:59:14 +05:30
parent 263a07d58d
commit 03b3d1d901
2 changed files with 90 additions and 50 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

114
Java/src/main/java/com/gildedrose/GildedRose.java
View File

@ -8,55 +8,71 @@ class GildedRose {
} }
public void updateQuality() { public void updateQuality() {
for (int i = 0; i < items.length; i++) { for (Item item : items) {
if (!items[i].name.equals("Aged Brie") String name = item.name;
&& !items[i].name.equals("Backstage passes to a TAFKAL80ETC concert")) { updateSellIn(item, name);
if (items[i].quality > 0) { switch (name) {
if (!items[i].name.equals("Sulfuras, Hand of Ragnaros")) { case "Sulfuras, Hand of Ragnaros":
items[i].quality = items[i].quality - 1; break;
} case "Aged Brie":
} increaseQualityByOne(item);
} else { break;
if (items[i].quality < 50) { case "Backstage passes to a TAFKAL80ETC concert":
items[i].quality = items[i].quality + 1; updateBackstagePassesQuality(item);
break;
if (items[i].name.equals("Backstage passes to a TAFKAL80ETC concert")) { case "Conjured Mana Cake":
if (items[i].sellIn < 11) { updateConjuredQuality(item);
if (items[i].quality < 50) { break;
items[i].quality = items[i].quality + 1; default:
} updateQualityOfDefaultItems(item);
} break;
if (items[i].sellIn < 6) {
if (items[i].quality < 50) {
items[i].quality = items[i].quality + 1;
}
}
}
}
}
if (!items[i].name.equals("Sulfuras, Hand of Ragnaros")) {
items[i].sellIn = items[i].sellIn - 1;
}
if (items[i].sellIn < 0) {
if (!items[i].name.equals("Aged Brie")) {
if (!items[i].name.equals("Backstage passes to a TAFKAL80ETC concert")) {
if (items[i].quality > 0) {
if (!items[i].name.equals("Sulfuras, Hand of Ragnaros")) {
items[i].quality = items[i].quality - 1;
}
}
} else {
items[i].quality = items[i].quality - items[i].quality;
}
} else {
if (items[i].quality < 50) {
items[i].quality = items[i].quality + 1;
}
}
} }
} }
} }
}
private void updateQualityOfDefaultItems(Item item) {
if (item.sellIn >= 0)
decreaseQualityByOne(item);
else {
decreaseQualityByOne(item);
decreaseQualityByOne(item);
}
}
private void decreaseQualityByOne(Item item) {
if (item.quality > 0)
item.quality--;
}
private void updateSellIn(Item item, String name) {
if (!name.equals("Sulfuras, Hand of Ragnaros")) {
item.sellIn = item.sellIn - 1;
}
}
private void updateConjuredQuality(Item item) {
decreaseQualityByOne(item);
decreaseQualityByOne(item);
}
private void increaseQualityByOne(Item item) {
if (isValueLessThanBy(item.quality, 50)) {
item.quality++;
}
}
private boolean isValueLessThanBy(int value, int target) {
return value < target;
}
/*Quality increases by 2 when there are 10 days or less and by 3 when there are 5 days or less but
Quality drops to 0 after the concert*/
private void updateBackstagePassesQuality(Item item) {
if (isValueLessThanBy(item.sellIn, 11)) {
increaseQualityByOne(item);
increaseQualityByOne(item);
}
if (isValueLessThanBy(item.sellIn, 6) || item.sellIn > 10)
increaseQualityByOne(item);
}
}

26
Java/src/test/java/com/gildedrose/GildedRoseTest.java
View File

@ -8,10 +8,34 @@ class GildedRoseTest {
@Test @Test
void foo() { void foo() {
Item[] items = new Item[] { new Item("foo", 0, 0) }; Item[] items = new Item[] { new Item("fixme", 0, 0) };
GildedRose app = new GildedRose(items); GildedRose app = new GildedRose(items);
app.updateQuality(); app.updateQuality();
assertEquals("fixme", app.items[0].name); assertEquals("fixme", app.items[0].name);
} }
@Test
void agedBrieTest() {
Item[] items = new Item[] { new Item("Aged Brie", 2, 0) };
GildedRose app = new GildedRose(items);
app.updateQuality();
assertEquals("Aged Brie", app.items[0].name);
assertEquals(1, app.items[0].quality);
assertEquals(1, app.items[0].sellIn);
app.updateQuality();
assertEquals(2, app.items[0].quality);
assertEquals(0, app.items[0].sellIn);
}
@Test
void conjuredTest() {
Item[] items = new Item[] { new Item("Conjured Mana Cake", 3, 6) };
GildedRose app = new GildedRose(items);
app.updateQuality();
assertEquals("Conjured Mana Cake", app.items[0].name);
assertEquals(4, app.items[0].quality);
assertEquals(2, app.items[0].sellIn);
app.updateQuality();
assertEquals(2, app.items[0].quality);
assertEquals(1, app.items[0].sellIn);
}
} }