OpenSource/GildedRose-Refactoring-Kata
1
0
Fork 0
mirror of https://github.com/emilybache/GildedRose-Refactoring-Kata.git synced 2026-02-17 23:41:27 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Refactor rate and use abs to convert negative rate to positive

Browse Source
This commit is contained in:
leslie-alldridge 2022-11-22 09:24:57 +13:00
parent 0137da6395
commit 04221a6986
2 changed files with 12 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
python/gilded_rose.py
View File

@ -20,11 +20,10 @@ class GildedRose(object):
item.sell_in -= 1 item.sell_in -= 1
has_positive_sell_in = item.sell_in >= 0 has_positive_sell_in = item.sell_in >= 0
rate = -1 rate = -1 if has_positive_sell_in else -2
if item.name == "Aged Brie": if item.name == "Aged Brie":
rate = 1 if has_positive_sell_in else 2 rate = abs(rate)
return self.adjust_quality(item, rate)
if item.name == "Backstage passes to a TAFKAL80ETC concert": if item.name == "Backstage passes to a TAFKAL80ETC concert":
if 5 <= item.sell_in <= 10: if 5 <= item.sell_in <= 10:
@ -32,14 +31,12 @@ class GildedRose(object):
elif 0 <= item.sell_in <= 5: elif 0 <= item.sell_in <= 5:
rate = 3 rate = 3
else: else:
rate = -item.quality rate = 1 if has_positive_sell_in else -item.quality
return self.adjust_quality(item, rate)
if "Conjured" in item.name: if "Conjured" in item.name:
rate = -2 if has_positive_sell_in else -4 rate *= 2
return self.adjust_quality(item, rate)
return self.adjust_quality(item, -1) if has_positive_sell_in else self.adjust_quality(item, -2) return self.adjust_quality(item, rate)
class Item: class Item:

7
python/test_gilded_rose.py
View File

@ -63,6 +63,13 @@ class GildedRoseTest(unittest.TestCase):
Quality increases by 2 when there are 10 days or less and by 3 when there are 5 days or less but Quality increases by 2 when there are 10 days or less and by 3 when there are 5 days or less but
Quality drops to 0 after the concert Quality drops to 0 after the concert
""" """
# Standard - quality increases with age
items = [Item("Backstage passes to a TAFKAL80ETC concert", 15, 10)]
gilded_rose = GildedRose(items)
gilded_rose.update_quality()
self.assertEqual(11, items[0].quality)
# Ten days or less - quality increases by 2 # Ten days or less - quality increases by 2
items = [Item("Backstage passes to a TAFKAL80ETC concert", 9, 10)] items = [Item("Backstage passes to a TAFKAL80ETC concert", 9, 10)]
gilded_rose = GildedRose(items) gilded_rose = GildedRose(items)