OpenSource/GildedRose-Refactoring-Kata
1
0
Fork 0
mirror of https://github.com/emilybache/GildedRose-Refactoring-Kata.git synced 2026-02-21 01:11:08 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

further refactor

Browse Source
This commit is contained in:
cammp325 2022-07-02 12:49:55 -04:00
parent 96382b8834
commit 0815c27195
1 changed files with 25 additions and 30 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

41
Java/src/main/java/com/gildedrose/GildedRose.java
View File

@ -19,29 +19,24 @@ class GildedRose {
}
private void updateItemQuality(Item item) {
int adjustment;
if (!item.name.equals(AGED_BRIE)
&& !item.name.equals(BACKSTAGE)) {
if (item.quality > 0) {
if (!item.name.equals(SULFURAS)) {
item.quality = item.quality - 1;
adjustQuality(item, adjustment=-1);
}
}
} else {
if (item.quality < 50) {
item.quality = item.quality + 1;
adjustQuality(item, adjustment=+1);
if (item.name.equals(BACKSTAGE)) {
if (item.sellIn < 11) {
if (item.quality < 50) {
item.quality = item.quality + 1;
}
}
if (item.name.equals(BACKSTAGE)) {
if (item.sellIn < 11) {
adjustQuality(item, adjustment=1);
}
if (item.sellIn < 6) {
if (item.quality < 50) {
item.quality = item.quality + 1;
}
}
if (item.sellIn < 6) {
adjustQuality(item, adjustment=1);
}
}
}
@ -53,25 +48,25 @@ class GildedRose {
if (item.sellIn < 0) {
if (!item.name.equals(AGED_BRIE)) {
if (!item.name.equals(BACKSTAGE)) {
if (item.quality > 0) {
if (!item.name.equals(SULFURAS)) {
item.quality = item.quality - 1;
}
if (!item.name.equals(SULFURAS)) {
adjustQuality(item, adjustment=-1);
}
} else {
item.quality = item.quality - item.quality;
}
} else {
if (item.quality < 50) {
int adjustment = 1;
adjustQuality(item, adjustment);
}
int adjustment = 1;
adjustQuality(item, adjustment);
}
}
}
public void adjustQuality(Item item, int adjustment) {
item.quality = item.quality + adjustment;
int newQuality = item.quality + adjustment;
boolean isValid = newQuality <= 50 && newQuality >= 0;
if (isValid) {
item.quality = newQuality;
}
}
public Item[] getItems() {