OpenSource/GildedRose-Refactoring-Kata
1
0
Fork 0
mirror of https://github.com/emilybache/GildedRose-Refactoring-Kata.git synced 2026-02-16 06:51:27 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

update updateExpired method

Browse Source 
update updateExpired method to process Aged Brie then Backstage passes then Sulfuras then all the rest items

also refactoring increase and decease quality methods to prevent duplication code and for easy maintain
This commit is contained in:
Trobax 2022-11-23 17:14:08 +01:00
parent e0c5b8b5bd
commit 0d3aefb6c8
1 changed files with 28 additions and 27 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

55
Java/src/main/java/com/gildedrose/GildedRose.java
View File

@ -23,32 +23,27 @@ class GildedRose {
private static void updateQuality(Item item) {
if (item.name.equals("Aged Brie")) {
if (item.quality < 50) {
item.quality++;
}
increaseQuality(item);
} else if (item.name.equals("Backstage passes to a TAFKAL80ETC concert")) {
increaseQuality(item);
if (item.sellIn < 11) {
if (item.quality < 50) {
item.quality++;
}
increaseQuality(item);
}
if (item.sellIn < 6) {
if (item.quality < 50) {
item.quality++;
}
increaseQuality(item);
}
} else if (item.name.equals("Sulfuras, Hand of Ragnaros")) {
return;
} else if (item.quality > 0) {
item.quality--;
}
} else decreaseQuality(item);
}
private static void updateSelling(Item item) {
if (!item.name.equals("Sulfuras, Hand of Ragnaros")) {
item.sellIn--;
if (item.name.equals("Sulfuras, Hand of Ragnaros")) {
return;
}
item.sellIn--;
}
private static boolean isExpired(Item item) {
@ -56,20 +51,26 @@ class GildedRose {
}
private static void updateExpired(Item item) {
if (!item.name.equals("Aged Brie")) {
if (!item.name.equals("Backstage passes to a TAFKAL80ETC concert")) {
if (item.quality > 0) {
if (!item.name.equals("Sulfuras, Hand of Ragnaros")) {
item.quality--;
}
}
} else {
item.quality = 0;
}
if (item.name.equals("Aged Brie")) {
increaseQuality(item);
} else if (item.name.equals("Backstage passes to a TAFKAL80ETC concert")) {
item.quality = 0;
} else if (item.name.equals("Sulfuras, Hand of Ragnaros")) {
return;
} else {
if (item.quality < 50) {
item.quality++;
}
decreaseQuality(item);
}
}
private static void increaseQuality(Item item) {
if (item.quality < 50) {
item.quality++;
}
}
private static void decreaseQuality(Item item) {
if (item.quality > 0) {
item.quality--;
}
}
}