OpenSource/GildedRose-Refactoring-Kata
1
0
Fork 0
mirror of https://github.com/emilybache/GildedRose-Refactoring-Kata.git synced 2026-02-15 22:41:30 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Extract updating quality of standard item

Browse Source
This commit is contained in:
Dan Holmes 2020-12-03 15:00:16 +00:00
parent 65f7a1f0db
commit 114efeff62
1 changed files with 14 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
js-jasmine/src/shop.js
View File

@ -16,27 +16,29 @@ class Shop {
this._updateQualityBackstagePass(item); this._updateQualityBackstagePass(item);
} else if (item.name == 'Aged Brie') { } else if (item.name == 'Aged Brie') {
this._updateQualityAgedBrie(item); this._updateQualityAgedBrie(item);
} else if (item.name == 'Sulfuras, Hand of Ragnaros') {
} else { } else {
if (item.name != 'Sulfuras, Hand of Ragnaros') { this._updateQualityStandard(item)
item.quality = item.quality - 1;
}
this._updateSellIn(item)
if (item.sellIn < 0) {
if (item.name != 'Sulfuras, Hand of Ragnaros') {
item.quality = item.quality - 1;
}
}
} }
this._updateSellIn(item)
this._checkMaxQuality(item); this._checkMaxQuality(item);
this._checkMinQuality(item); this._checkMinQuality(item);
} }
_updateQualityStandard(item) {
if (item.sellIn <= 0) {
item.quality -= 2;
} else {
item.quality -= 1;
}
}
_updateQualityBackstagePass(item) { _updateQualityBackstagePass(item) {
if (item.sellIn <= 0) { if (item.sellIn <= 0) {
item.quality = 0; item.quality = 0;
} else if (item.sellIn < 6) { } else if (item.sellIn <= 5) {
item.quality += 3; item.quality += 3;
} else if (item.sellIn < 11) { } else if (item.sellIn <= 10) {
item.quality += 2; item.quality += 2;
} else { } else {
item.quality += 1; item.quality += 1;
@ -44,7 +46,7 @@ class Shop {
} }
_updateQualityAgedBrie(item) { _updateQualityAgedBrie(item) {
if (item.sellIn < 0) { if (item.sellIn <= 0) {
item.quality += 2; item.quality += 2;
} else { } else {
item.quality += 1; item.quality += 1;