From 138ad0daab6e511ee60579e28c8421e69380b245 Mon Sep 17 00:00:00 2001 From: Jesper Date: Wed, 13 Apr 2022 16:35:03 +0200 Subject: [PATCH] Move conditional into sellInBelow0 --- TypeScript/app/gilded-rose.ts | 33 ++++++++++++++++----------------- 1 file changed, 16 insertions(+), 17 deletions(-) diff --git a/TypeScript/app/gilded-rose.ts b/TypeScript/app/gilded-rose.ts index 21c9aa73..f34c26a9 100644 --- a/TypeScript/app/gilded-rose.ts +++ b/TypeScript/app/gilded-rose.ts @@ -45,32 +45,31 @@ export class GildedRose { if (item.name != 'Sulfuras, Hand of Ragnaros') { item.sellIn = item.sellIn - 1; } - if (item.sellIn < 0) { - item.quality = this.sellInBelow0(item) - } + item.quality = this.sellInBelow0(item) }) return this.items; } private sellInBelow0(item: Item): number { - if (item.name == 'Sulfuras, Hand of Ragnaros') return item.quality; + if (item.sellIn < 0) { + if (item.name == 'Sulfuras, Hand of Ragnaros') return item.quality; - if (item.name == 'Aged Brie') { - if (item.quality < 50) { - return item.quality + 1 + if (item.name == 'Aged Brie') { + if (item.quality < 50) { + return item.quality + 1 + } + return item.quality + } + + if (item.name == 'Backstage passes to a TAFKAL80ETC concert') { + return 0 + } + + if (item.quality > 0) { + return item.quality - 1 } - return item.quality } - - if (item.name == 'Backstage passes to a TAFKAL80ETC concert') { - return 0 - } - - if (item.quality > 0) { - return item.quality - 1 - } - return item.quality } }