OpenSource/GildedRose-Refactoring-Kata
1
0
Fork 0
mirror of https://github.com/emilybache/GildedRose-Refactoring-Kata.git synced 2026-02-16 06:51:27 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

refactor: adding a guard clause in the updateItem method

Browse Source
This commit is contained in:
pierre 2023-02-19 14:07:23 +01:00
parent 0514a8ea67
commit 15f4d079a6
1 changed files with 15 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

34
Java/src/main/java/com/gildedrose/GildedRose.java
View File

@ -11,19 +11,17 @@ class GildedRose {
for (int i = 0; i < items.length; i++) { for (int i = 0; i < items.length; i++) {
if (!items[i].name.equals("Aged Brie") if (!items[i].name.equals("Aged Brie")
&& !items[i].name.equals("Backstage passes to a TAFKAL80ETC concert")) { && !items[i].name.equals("Backstage passes to a TAFKAL80ETC concert")) {
if (items[i].quality > 0) { updateItem(items[i]);
updateItem(items[i]);
}
} else { } else {
if (items[i].quality < 50) { if (items[i].quality < 50) {
items[i].quality = items[i].quality + 1; items[i].quality = items[i].quality + 1;
if (items[i].name.equals("Backstage passes to a TAFKAL80ETC concert") && (items[i].quality < 50)) { if (items[i].name.equals("Backstage passes to a TAFKAL80ETC concert")) {
if (items[i].sellIn < 11) { if (items[i].sellIn < 11 && items[i].quality < 50) {
items[i].quality = items[i].quality + 1; items[i].quality = items[i].quality + 1;
} }
if (items[i].sellIn < 6) { if (items[i].sellIn < 6 && items[i].quality < 50) {
items[i].quality = items[i].quality + 1; items[i].quality = items[i].quality + 1;
} }
} }
} }
@ -36,9 +34,7 @@ class GildedRose {
if (items[i].sellIn < 0) { if (items[i].sellIn < 0) {
if (!items[i].name.equals("Aged Brie")) { if (!items[i].name.equals("Aged Brie")) {
if (!items[i].name.equals("Backstage passes to a TAFKAL80ETC concert")) { if (!items[i].name.equals("Backstage passes to a TAFKAL80ETC concert")) {
if (items[i].quality > 0) { updateItem(items[i]);
updateItem(items[i]);
}
} else { } else {
items[i].quality = items[i].quality - items[i].quality; items[i].quality = items[i].quality - items[i].quality;
} }
@ -50,16 +46,16 @@ class GildedRose {
} }
} }
} }
public void updateItem(Item item){
if (!item.name.equals("Sulfuras, Hand of Ragnaros")) {
item.quality = item.quality - 1;
if (item.name.equals("Conjured Mana Cake") && item.quality > 0) { public void updateItem(Item item) {
item.quality = item.quality - 1; if (item.quality > 0 & !item.name.equals("Sulfuras, Hand of Ragnaros")) {
} item.quality = item.quality - 1;
}
if (item.name.equals("Conjured Mana Cake") && item.quality > 0) {
item.quality = item.quality - 1;
}
}
} }
} }