OpenSource/GildedRose-Refactoring-Kata
1
0
Fork 0
mirror of https://github.com/emilybache/GildedRose-Refactoring-Kata.git synced 2026-02-15 06:21:29 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Add constants for Quality min/max

Browse Source
This commit is contained in:
Sarah Ashri 2024-03-13 09:49:27 +10:00
parent c657256ed9
commit 165322b336
1 changed files with 8 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
csharpcore/GildedRose/GildedRose.cs
View File

@ -5,6 +5,8 @@ namespace GildedRoseKata;
public class GildedRose public class GildedRose
{ {
private readonly IList<Item> _items; private readonly IList<Item> _items;
const int MinQuality = 0;
const int MaxQuality = 50;
public GildedRose(IList<Item> items) public GildedRose(IList<Item> items)
{ {
@ -23,7 +25,7 @@ public class GildedRose
{ {
if (item.Name != "Aged Brie" && item.Name != "Backstage passes to a TAFKAL80ETC concert") if (item.Name != "Aged Brie" && item.Name != "Backstage passes to a TAFKAL80ETC concert")
{ {
if (item.Quality > 0) if (item.Quality > MinQuality)
{ {
if (item.Name != "Sulfuras, Hand of Ragnaros") if (item.Name != "Sulfuras, Hand of Ragnaros")
{ {
@ -33,7 +35,7 @@ public class GildedRose
} }
else else
{ {
if (item.Quality < 50) if (item.Quality < MaxQuality)
{ {
item.Quality = item.Quality + 1; item.Quality = item.Quality + 1;
@ -41,7 +43,7 @@ public class GildedRose
{ {
if (item.SellIn < 11) if (item.SellIn < 11)
{ {
if (item.Quality < 50) if (item.Quality < MaxQuality)
{ {
item.Quality = item.Quality + 1; item.Quality = item.Quality + 1;
} }
@ -49,7 +51,7 @@ public class GildedRose
if (item.SellIn < 6) if (item.SellIn < 6)
{ {
if (item.Quality < 50) if (item.Quality < MaxQuality)
{ {
item.Quality = item.Quality + 1; item.Quality = item.Quality + 1;
} }
@ -69,7 +71,7 @@ public class GildedRose
{ {
if (item.Name != "Backstage passes to a TAFKAL80ETC concert") if (item.Name != "Backstage passes to a TAFKAL80ETC concert")
{ {
if (item.Quality > 0) if (item.Quality > MinQuality)
{ {
if (item.Name != "Sulfuras, Hand of Ragnaros") if (item.Name != "Sulfuras, Hand of Ragnaros")
{ {
@ -84,7 +86,7 @@ public class GildedRose
} }
else else
{ {
if (item.Quality < 50) if (item.Quality < MaxQuality)
{ {
item.Quality = item.Quality + 1; item.Quality = item.Quality + 1;
} }