OpenSource/GildedRose-Refactoring-Kata
1
0
Fork 0
mirror of https://github.com/emilybache/GildedRose-Refactoring-Kata.git synced 2026-02-18 16:01:42 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Refactor: replace this.items[i] to item

Browse Source
This commit is contained in:
Gayun00 2023-09-23 23:12:52 +09:00
parent 99177b74a0
commit 16d0d0c5a0
1 changed files with 25 additions and 29 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

54
TypeScript/app/gilded-rose.ts
View File

@ -20,51 +20,47 @@ export class GildedRose {
} }
updateQuality() { updateQuality() {
for (let i = 0; i < this.items.length; i++) { for (const item of this.items) {
if ( if (item.name != ITEMS.BRIE && item.name != ITEMS.PASSES) {
this.items[i].name != ITEMS.BRIE && if (item.quality > 0) {
this.items[i].name != ITEMS.PASSES if (item.name != ITEMS.SURFRAS) {
) { item.quality = item.quality - 1;
if (this.items[i].quality > 0) {
if (this.items[i].name != ITEMS.SURFRAS) {
this.items[i].quality = this.items[i].quality - 1;
} }
} }
} else { } else {
if (this.items[i].quality < 50) { if (item.quality < 50) {
this.items[i].quality = this.items[i].quality + 1; item.quality = item.quality + 1;
if (this.items[i].name == ITEMS.PASSES) { if (item.name == ITEMS.PASSES) {
if (this.items[i].sellIn < 11) { if (item.sellIn < 11) {
if (this.items[i].quality < 50) { if (item.quality < 50) {
this.items[i].quality = this.items[i].quality + 1; item.quality = item.quality + 1;
} }
} }
if (this.items[i].sellIn < 6) { if (item.sellIn < 6) {
if (this.items[i].quality < 50) { if (item.quality < 50) {
this.items[i].quality = this.items[i].quality + 1; item.quality = item.quality + 1;
} }
} }
} }
} }
} }
if (this.items[i].name != ITEMS.SURFRAS) { if (item.name != ITEMS.SURFRAS) {
this.items[i].sellIn = this.items[i].sellIn - 1; item.sellIn = item.sellIn - 1;
} }
if (this.items[i].sellIn < 0) { if (item.sellIn < 0) {
if (this.items[i].name != ITEMS.BRIE) { if (item.name != ITEMS.BRIE) {
if (this.items[i].name != ITEMS.PASSES) { if (item.name != ITEMS.PASSES) {
if (this.items[i].quality > 0) { if (item.quality > 0) {
if (this.items[i].name != ITEMS.SURFRAS) { if (item.name != ITEMS.SURFRAS) {
this.items[i].quality = this.items[i].quality - 1; item.quality = item.quality - 1;
} }
} }
} else { } else {
this.items[i].quality = item.quality = item.quality - item.quality;
this.items[i].quality - this.items[i].quality;
} }
} else { } else {
if (this.items[i].quality < 50) { if (item.quality < 50) {
this.items[i].quality = this.items[i].quality + 1; item.quality = item.quality + 1;
} }
} }
} }