From 172bb39d30eac4d18d340e46493558c384dda498 Mon Sep 17 00:00:00 2001 From: Kirti Deshmukh Date: Fri, 3 Feb 2023 08:05:11 +0530 Subject: [PATCH] add tests for conjured on and after sellIn date is zero --- Java/src/main/java/com/gildedrose/GildedRose.java | 3 ++- Java/src/test/java/com/gildedrose/GildedRoseTest.java | 8 ++++++-- 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/Java/src/main/java/com/gildedrose/GildedRose.java b/Java/src/main/java/com/gildedrose/GildedRose.java index 766c1e39..9b7aa822 100644 --- a/Java/src/main/java/com/gildedrose/GildedRose.java +++ b/Java/src/main/java/com/gildedrose/GildedRose.java @@ -18,8 +18,9 @@ class GildedRose { private void updateQualityForConjured(Item item) { if (item.sellIn > 0) { - item.quality = degradeQualityBy(item.quality, 2); + } else { + item.quality = degradeQualityBy(item.quality, 4); } item.sellIn = item.sellIn - 1; } diff --git a/Java/src/test/java/com/gildedrose/GildedRoseTest.java b/Java/src/test/java/com/gildedrose/GildedRoseTest.java index cc4f51ac..b4a7d0e4 100644 --- a/Java/src/test/java/com/gildedrose/GildedRoseTest.java +++ b/Java/src/test/java/com/gildedrose/GildedRoseTest.java @@ -23,11 +23,15 @@ class GildedRoseTest { Arguments.of(new GildedRose(new Item[]{new Item("Normal Item", 0, 0)}), "Normal Item", -1, 0), Arguments.of(new GildedRose(new Item[]{new Item("Normal Item", 0, 10)}), "Normal Item", -1, 8), - //1. Conjured item - //1.a Before sellIn + //2. Conjured item + //2.a Before sellIn Arguments.of(new GildedRose(new Item[]{new Item("Conjured Mana Cake", 1, 10)}), "Conjured Mana Cake", 0, 8), Arguments.of(new GildedRose(new Item[]{new Item("Conjured Mana Cake", 1, 0)}), "Conjured Mana Cake", 0, 0), + //2.b after sellIn + Arguments.of(new GildedRose(new Item[]{new Item("Conjured Mana Cake", 0, 0)}),"Conjured Mana Cake", -1, 0), + Arguments.of(new GildedRose(new Item[]{new Item("Conjured Mana Cake", 0, 10)}), "Conjured Mana Cake", -1, 6), + Arguments.of(new GildedRose(new Item[]{new Item("+5 Dexterity Vest", 10, 20)}), "+5 Dexterity Vest", 9, 19),