OpenSource/GildedRose-Refactoring-Kata
1
0
Fork 0
mirror of https://github.com/emilybache/GildedRose-Refactoring-Kata.git synced 2026-02-15 14:31:28 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

make the first if condition positive

Browse Source
This commit is contained in:
brianblessou 2019-05-12 15:16:17 +02:00
parent df0319f849
commit 1aae554b54
1 changed files with 12 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

28
Java/src/main/java/com/gildedrose/GildedRose.java
View File

@ -20,41 +20,37 @@ class GildedRose {
} }
public void updateQuality() { public void updateQuality() {
String SULFURA = "Sulfuras, Hand of Ragnaros";
String AGED_BRIE = "Aged Brie";
String BACKSTAGE = "Backstage passes to a TAFKAL80ETC concert";
for (Item item : items) { for (Item item : items) {
if (item.name.equals("Sulfuras, Hand of Ragnaros")) { if (item.name.equals(SULFURA)) {
continue; continue;
} }
/* if (!item.name.equals("Aged Brie")) { if (item.name.equals(AGED_BRIE) || item.name.equals(BACKSTAGE)) {
if (!item.name.equals("Backstage passes to a TAFKAL80ETC concert")) {
decreaseQuality(item);
}
}*/
if (!item.name.equals("Aged Brie")
&& !item.name.equals("Backstage passes to a TAFKAL80ETC concert")) {
decreaseQuality(item);
} else {
increaseQuality(item); increaseQuality(item);
if (item.name.equals("Backstage passes to a TAFKAL80ETC concert")) { if (item.name.equals(BACKSTAGE)) {
if (item.sellIn < 11) { if (item.sellIn < 11) {
increaseQuality(item); increaseQuality(item);
} }
if (item.sellIn < 6) { if (item.sellIn < 6) {
increaseQuality(item); increaseQuality(item);
} }
} }
} else {
decreaseQuality(item);
} }
item.sellIn = item.sellIn - 1; item.sellIn = item.sellIn - 1;
if (item.sellIn < 0) { if (item.sellIn < 0) {
if (item.name.equals("Aged Brie")) { if (item.name.equals(AGED_BRIE)) {
increaseQuality(item); increaseQuality(item);
} else if (item.name.equals("Backstage passes to a TAFKAL80ETC concert")) { } else if (item.name.equals(BACKSTAGE)) {
item.quality -= item.quality; item.quality -= item.quality;
} else { } else {
decreaseQuality(item); decreaseQuality(item);