From 1b72b9b9378b5311a574f741c8ce47dd4571321e Mon Sep 17 00:00:00 2001
From: Konstantin Pavlov <git@konstantinpavlov.net>
Date: Mon, 24 Jun 2019 07:40:23 +0200
Subject: [PATCH] extract Aged Brie tests, verify that The Quality of an item
 is never more than 50

---
 .../gildedrose/GildedRoseAgedBrieTest.java    | 48 +++++++++++++++++++
 .../java/com/gildedrose/GildedRoseTest.java   | 31 ------------
 2 files changed, 48 insertions(+), 31 deletions(-)
 create mode 100644 Java/src/test/java/com/gildedrose/GildedRoseAgedBrieTest.java

diff --git a/Java/src/test/java/com/gildedrose/GildedRoseAgedBrieTest.java b/Java/src/test/java/com/gildedrose/GildedRoseAgedBrieTest.java
new file mode 100644
index 00000000..005322a0
--- /dev/null
+++ b/Java/src/test/java/com/gildedrose/GildedRoseAgedBrieTest.java
@@ -0,0 +1,48 @@
+package com.gildedrose;
+
+import io.qameta.allure.Feature;
+import lombok.val;
+import org.junit.jupiter.params.ParameterizedTest;
+import org.junit.jupiter.params.provider.ValueSource;
+
+import static com.gildedrose.TestHelper.assertItem;
+import static com.gildedrose.TestHelper.prepareApp;
+import static java.lang.Math.min;
+import static org.apache.commons.lang3.RandomUtils.nextInt;
+
+
+class GildedRoseAgedBrieTest {
+
+    @Feature("The Quality of an item is never more than 50")
+    @ParameterizedTest(name = "Initial quality: {arguments}")
+    @ValueSource(ints = {49, 50})
+    void shouldNotIncreaseQualityAbove50(int initialQuality) {
+        // given
+        val initialSellIn = nextInt(3, 50);
+        GildedRose app = prepareApp(new Item("Aged Brie", initialSellIn, initialQuality));
+
+        // when
+        app.updateQuality();
+
+        // then
+        final Item item = app.items[0];
+        assertItem(item, "Aged Brie", initialSellIn - 1, 50);
+    }
+
+    @Feature("\"Aged Brie\" actually increases in Quality the older it gets")
+    @Feature("The Quality of an item is never more than 50")
+    @ParameterizedTest(name = "Initial quality: {arguments}")
+    @ValueSource(ints = {0, 1, 49, 50})
+    void shouldIncreaseQualityForAgedBrie(int initialQuality) {
+        // given
+        GildedRose app = prepareApp(new Item("Aged Brie", 1, initialQuality));
+
+        // when
+        app.updateQuality();
+
+        // then
+        final Item item = app.items[0];
+        final int expectedQuality = min(initialQuality + 1, 50);
+        assertItem(item, "Aged Brie", 0, expectedQuality);
+    }
+}
diff --git a/Java/src/test/java/com/gildedrose/GildedRoseTest.java b/Java/src/test/java/com/gildedrose/GildedRoseTest.java
index 2ffdb63a..5b261ae3 100644
--- a/Java/src/test/java/com/gildedrose/GildedRoseTest.java
+++ b/Java/src/test/java/com/gildedrose/GildedRoseTest.java
@@ -8,25 +8,11 @@ import org.junit.jupiter.params.provider.ValueSource;
 
 import static com.gildedrose.TestHelper.assertItem;
 import static com.gildedrose.TestHelper.prepareApp;
-import static java.lang.Math.min;
 import static org.apache.commons.lang3.RandomUtils.nextInt;
 
 
 class GildedRoseTest {
 
-    @Test
-    void shouldProcessFooItem() {
-        // given
-        GildedRose app = prepareApp(new Item("foo", 0, 0));
-
-        // when
-        app.updateQuality();
-
-        // then
-        final Item item = app.items[0];
-        assertItem(item, "foo", -1, 0);
-    }
-
     @Feature("The Quality of an item is never negative")
     @ParameterizedTest(name = "Initial quality: {arguments}")
     @ValueSource(ints = {0, 1})
@@ -74,21 +60,4 @@ class GildedRoseTest {
         final Item item = app.items[0];
         assertItem(item, itemName, initialSellIn, initialQuality);
     }
-
-    @Feature("\"Aged Brie\" actually increases in Quality the older it gets")
-    @Feature("The Quality of an item is never more than 50")
-    @ParameterizedTest(name = "Initial quality: {arguments}")
-    @ValueSource(ints = {0, 1, 49, 50})
-    void shouldIncreaseQualityForAgedBrie(int initialQuality) {
-        // given
-        GildedRose app = prepareApp(new Item("Aged Brie", 1, initialQuality));
-
-        // when
-        app.updateQuality();
-
-        // then
-        final Item item = app.items[0];
-        final int expectedQuality = min(initialQuality + 1, 50);
-        assertItem(item, "Aged Brie", 0, expectedQuality);
-    }
 }