OpenSource/GildedRose-Refactoring-Kata
1
0
Fork 0
mirror of https://github.com/emilybache/GildedRose-Refactoring-Kata.git synced 2026-02-16 06:51:27 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Improved global constants located in one place.

Browse Source
This commit is contained in:
israel 2017-10-20 11:51:20 +01:00
parent c54699a410
commit 20538bf65c
7 changed files with 34 additions and 26 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
csharp/StrategyPatternExample/CategoryStrategiesFactory.cs
View File

@ -1,4 +1,5 @@
using System; using csharp.StrategyPatternExample.Strategy;
using System;
using System.Collections.Generic; using System.Collections.Generic;
namespace csharp.StrategyPatternExample namespace csharp.StrategyPatternExample
@ -28,9 +29,7 @@ namespace csharp.StrategyPatternExample
return _strategiesFactory; return _strategiesFactory;
} }
#endregion
public List<ICategoryStrategy> GetCategoryStrategies(Item item) public List<ICategoryStrategy> GetCategoryStrategies(Item item)
{ {
List<ICategoryStrategy> listCategoryStrategies = new List<ICategoryStrategy>(); List<ICategoryStrategy> listCategoryStrategies = new List<ICategoryStrategy>();
@ -73,5 +72,7 @@ namespace csharp.StrategyPatternExample
return listCategoryStrategies; return listCategoryStrategies;
} }
#endregion
} }
} }

10
csharp/StrategyPatternExample/Global.cs Normal file
View File

@ -0,0 +1,10 @@
using System;
namespace csharp.StrategyPatternExample
{
static public class Global
{
public const int MAXIMUN_QUALITY = 50;
public const int MINIMUN_QUALITY = 0;
}
}

8
csharp/StrategyPatternExample/NextExpiredImproveQualityStrategy.cs → csharp/StrategyPatternExample/Strategies/NextExpiredImproveQualityStrategy.cs
View File

@ -1,6 +1,6 @@
using System; using System;
namespace csharp.StrategyPatternExample namespace csharp.StrategyPatternExample.Strategy
{ {
class NextExpiredImproveQualityStrategy : ICategoryStrategy class NextExpiredImproveQualityStrategy : ICategoryStrategy
{ {
@ -10,7 +10,7 @@ namespace csharp.StrategyPatternExample
if (item.SellIn < 0) if (item.SellIn < 0)
{ {
item.Quality = 0; item.Quality = Global.MINIMUN_QUALITY;
} }
else else
{ {
@ -27,9 +27,9 @@ namespace csharp.StrategyPatternExample
item.Quality += inc; item.Quality += inc;
if (item.Quality > 50) if (item.Quality > Global.MAXIMUN_QUALITY)
{ {
item.Quality = 50; item.Quality = Global.MAXIMUN_QUALITY;
} }
} }
} }

6
csharp/StrategyPatternExample/NormalDegradeStrategy.cs → csharp/StrategyPatternExample/Strategies/NormalDegradeStrategy.cs
View File

@ -1,19 +1,19 @@
using System; using System;
namespace csharp.StrategyPatternExample namespace csharp.StrategyPatternExample.Strategy
{ {
class NormalDegradeStrategy : ICategoryStrategy class NormalDegradeStrategy : ICategoryStrategy
{ {
public void Update(Item item) public void Update(Item item)
{ {
if (item.Quality > 0) if (item.Quality > Global.MINIMUN_QUALITY)
{ {
item.Quality--; item.Quality--;
} }
item.SellIn--; item.SellIn--;
if (item.SellIn < 0 && item.Quality > 0) if (item.SellIn < 0 && item.Quality > Global.MINIMUN_QUALITY)
{ {
item.Quality--; item.Quality--;
} }

10
csharp/StrategyPatternExample/OlderIsBetterStrategy.cs → csharp/StrategyPatternExample/Strategies/OlderIsBetterStrategy.cs
View File

@ -1,23 +1,19 @@
using System; using System;
using System.Collections.Generic;
using System.Linq;
using System.Text;
using System.Threading.Tasks;
namespace csharp.StrategyPatternExample namespace csharp.StrategyPatternExample.Strategy
{ {
class OlderIsBetterStrategy : ICategoryStrategy class OlderIsBetterStrategy : ICategoryStrategy
{ {
public void Update(Item item) public void Update(Item item)
{ {
if (item.Quality < 50) if (item.Quality < Global.MAXIMUN_QUALITY)
{ {
item.Quality++; item.Quality++;
} }
item.SellIn--; item.SellIn--;
if (item.SellIn < 0 && item.Quality < 50) if (item.SellIn < 0 && item.Quality < Global.MAXIMUN_QUALITY)
{ {
item.Quality++; item.Quality++;
} }

8
csharp/StrategyPatternExample/TwiceFastDegradeQualityStrategy.cs → csharp/StrategyPatternExample/Strategies/TwiceFastDegradeQualityStrategy.cs
View File

@ -1,6 +1,6 @@
using System; using System;
namespace csharp.StrategyPatternExample namespace csharp.StrategyPatternExample.Strategy
{ {
class TwiceFastDegradeQualityStrategy : ICategoryStrategy class TwiceFastDegradeQualityStrategy : ICategoryStrategy
{ {
@ -15,14 +15,14 @@ namespace csharp.StrategyPatternExample
degrade = 4; degrade = 4;
} }
if (item.Quality > 0) if (item.Quality > Global.MINIMUN_QUALITY)
{ {
item.Quality -= degrade; item.Quality -= degrade;
} }
if (item.Quality < 0) if (item.Quality < Global.MINIMUN_QUALITY)
{ {
item.Quality = 0; item.Quality = Global.MINIMUN_QUALITY;
} }
} }
} }

9
csharp/csharp.csproj
View File

@ -70,14 +70,15 @@
<Compile Include="IGildedRoseApp.cs" /> <Compile Include="IGildedRoseApp.cs" />
<Compile Include="Item.cs" /> <Compile Include="Item.cs" />
<Compile Include="StrategyPatternExample\CategoryStrategiesFactory.cs" /> <Compile Include="StrategyPatternExample\CategoryStrategiesFactory.cs" />
<Compile Include="StrategyPatternExample\Global.cs" />
<Compile Include="StrategyPatternExample\ICategoryStrategy.cs" /> <Compile Include="StrategyPatternExample\ICategoryStrategy.cs" />
<Compile Include="StrategyPatternExample\ItemWrapperContext.cs" /> <Compile Include="StrategyPatternExample\ItemWrapperContext.cs" />
<Compile Include="Program.cs" /> <Compile Include="Program.cs" />
<Compile Include="Properties\AssemblyInfo.cs" /> <Compile Include="Properties\AssemblyInfo.cs" />
<Compile Include="StrategyPatternExample\NextExpiredImproveQualityStrategy.cs" /> <Compile Include="StrategyPatternExample\Strategies\NextExpiredImproveQualityStrategy.cs" />
<Compile Include="StrategyPatternExample\NormalDegradeStrategy.cs" /> <Compile Include="StrategyPatternExample\Strategies\NormalDegradeStrategy.cs" />
<Compile Include="StrategyPatternExample\OlderIsBetterStrategy.cs" /> <Compile Include="StrategyPatternExample\Strategies\OlderIsBetterStrategy.cs" />
<Compile Include="StrategyPatternExample\TwiceFastDegradeQualityStrategy.cs" /> <Compile Include="StrategyPatternExample\Strategies\TwiceFastDegradeQualityStrategy.cs" />
</ItemGroup> </ItemGroup>
<ItemGroup> <ItemGroup>
<None Include="App.config" /> <None Include="App.config" />