Merge pull request #522 from danielmpetrov/refactor/csharp-core-update-framework-and-libs

[Refactor] .NET Core Templates - Update Framework and Libraries
This commit is contained in:
Emily Bache 2024-02-05 14:43:53 +01:00 committed by GitHub
commit 209c40323c
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
7 changed files with 27 additions and 22 deletions

View File

@ -2,7 +2,7 @@
<PropertyGroup> <PropertyGroup>
<OutputType>Exe</OutputType> <OutputType>Exe</OutputType>
<TargetFramework>net7.0</TargetFramework> <TargetFramework>net8.0</TargetFramework>
<StartupObject>GildedRoseKata.Program</StartupObject> <StartupObject>GildedRoseKata.Program</StartupObject>
</PropertyGroup> </PropertyGroup>

View File

@ -12,7 +12,6 @@ using Xunit;
namespace GildedRoseTests namespace GildedRoseTests
{ {
[UsesVerify]
public class ApprovalTest public class ApprovalTest
{ {
[Fact] [Fact]

View File

@ -1,15 +1,21 @@
<Project Sdk="Microsoft.NET.Sdk"> <Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup> <PropertyGroup>
<TargetFramework>net7.0</TargetFramework> <TargetFramework>net8.0</TargetFramework>
<IsPackable>false</IsPackable> <IsPackable>false</IsPackable>
</PropertyGroup> </PropertyGroup>
<ItemGroup> <ItemGroup>
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.0.0" /> <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.8.0" />
<PackageReference Include="Verify.Xunit" Version="14.11.4" /> <PackageReference Include="Verify.Xunit" Version="23.1.0" />
<PackageReference Include="xunit" Version="2.4.1" /> <PackageReference Include="xunit" Version="2.6.6" />
<PackageReference Include="xunit.runner.visualstudio" Version="2.4.3" /> <PackageReference Include="xunit.runner.visualstudio" Version="2.5.6">
<PackageReference Include="coverlet.collector" Version="3.1.0" /> <PrivateAssets>all</PrivateAssets>
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
</PackageReference>
<PackageReference Include="coverlet.collector" Version="6.0.0">
<PrivateAssets>all</PrivateAssets>
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
</PackageReference>
</ItemGroup> </ItemGroup>
<ItemGroup> <ItemGroup>

View File

@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk"> <Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup> <PropertyGroup>
<TargetFramework>net7.0</TargetFramework> <TargetFramework>net8.0</TargetFramework>
</PropertyGroup> </PropertyGroup>
</Project> </Project>

View File

@ -1,17 +1,16 @@
using System; using System;
using System.IO; using System.IO;
using System.Text; using System.Text;
using ApprovalTests; using System.Threading.Tasks;
using ApprovalTests.Reporters;
using NUnit.Framework; using NUnit.Framework;
using VerifyNUnit;
namespace GildedRoseTests; namespace GildedRoseTests;
[UseReporter(typeof(DiffReporter))]
public class ApprovalTest public class ApprovalTest
{ {
[Test] [Test]
public void ThirtyDays() public Task ThirtyDays()
{ {
var fakeOutput = new StringBuilder(); var fakeOutput = new StringBuilder();
Console.SetOut(new StringWriter(fakeOutput)); Console.SetOut(new StringWriter(fakeOutput));
@ -20,6 +19,6 @@ public class ApprovalTest
TextTestFixture.Main(new string[] { "30" }); TextTestFixture.Main(new string[] { "30" });
var output = fakeOutput.ToString(); var output = fakeOutput.ToString();
Approvals.Verify(output); return Verifier.Verify(output);
} }
} }

View File

@ -12,6 +12,6 @@ public class GildedRoseTest
var items = new List<Item> { new Item { Name = "foo", SellIn = 0, Quality = 0 } }; var items = new List<Item> { new Item { Name = "foo", SellIn = 0, Quality = 0 } };
var app = new GildedRose(items); var app = new GildedRose(items);
app.UpdateQuality(); app.UpdateQuality();
Assert.AreEqual("fixme", items[0].Name); Assert.That(items[0].Name, Is.EqualTo("fixme"));
} }
} }

View File

@ -2,17 +2,18 @@
<PropertyGroup> <PropertyGroup>
<OutputType>Exe</OutputType> <OutputType>Exe</OutputType>
<TargetFramework>net7.0</TargetFramework> <TargetFramework>net8.0</TargetFramework>
<StartupObject>GildedRoseTests.TextTestFixture</StartupObject> <StartupObject>GildedRoseTests.TextTestFixture</StartupObject>
</PropertyGroup> </PropertyGroup>
<ItemGroup> <ItemGroup>
<PackageReference Include="ApprovalTests" Version="5.9.0" /> <PackageReference Include="Verify.NUnit" Version="23.1.0" />
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.7.2" /> <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.8.0" />
<PackageReference Include="NUnit" Version="3.13.3" /> <PackageReference Include="NUnit" Version="4.0.1" />
<PackageReference Include="coverlet.collector" Version="6.0.0"><IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets> <PackageReference Include="coverlet.collector" Version="6.0.0">
<PrivateAssets>all</PrivateAssets> <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
</PackageReference> <PrivateAssets>all</PrivateAssets>
</PackageReference>
<PackageReference Include="NUnit3TestAdapter" Version="4.5.0" /> <PackageReference Include="NUnit3TestAdapter" Version="4.5.0" />
</ItemGroup> </ItemGroup>