OpenSource/GildedRose-Refactoring-Kata
1
0
Fork 0
mirror of https://github.com/emilybache/GildedRose-Refactoring-Kata.git synced 2026-02-18 07:51:29 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Inline unnecesary private method

Browse Source
This commit is contained in:
Bart Van der Plancken 2020-02-06 21:53:52 +01:00
parent 3e07a9abe9
commit 23246cb741
1 changed files with 3 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
Java/src/main/java/com/gildedrose/GildedRose.java
View File

@ -21,7 +21,7 @@ class GildedRose {
continue; continue;
} }
if (isEnhancingItem(item)) { if (isEnhancingItem(item)) {
int qualityOffset = determineQualityOffset(item); int qualityOffset = determineEnhancingQualityOffset(item);
item.quality = Integer.min(item.quality + qualityOffset, MAX_QUALITY); item.quality = Integer.min(item.quality + qualityOffset, MAX_QUALITY);
} else { } else {
int qualityOffset = 1; int qualityOffset = 1;
@ -31,7 +31,7 @@ class GildedRose {
item.quality = Integer.max(MIN_QUALITY, item.quality - qualityOffset); item.quality = Integer.max(MIN_QUALITY, item.quality - qualityOffset);
} }
updateSellInValue(item); item.sellIn -= 1;
} }
} }
@ -55,7 +55,7 @@ class GildedRose {
* @param item * @param item
* @return * @return
*/ */
private int determineQualityOffset(Item item) { private int determineEnhancingQualityOffset(Item item) {
int qualityOffset = 1; int qualityOffset = 1;
if (item.name.equals(BACKSTAGE_PASSES)) { if (item.name.equals(BACKSTAGE_PASSES)) {
if (isExperingSale(item)) { if (isExperingSale(item)) {
@ -91,11 +91,4 @@ class GildedRose {
private boolean isExperingSale(Item item) { private boolean isExperingSale(Item item) {
return item.sellIn < 11; return item.sellIn < 11;
} }
/**
* @param item the item of which the sell in value is updated
*/
private void updateSellInValue(Item item) {
item.sellIn -= 1;
}
} }