OpenSource/GildedRose-Refactoring-Kata
1
0 Fork 0
mirror of https://github.com/emilybache/GildedRose-Refactoring-Kata.git synced 2026-10-17 19:35:06 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Refactored test so that parametrized part is separated better and more explicit

Browse Source
This commit is contained in:
Stefan van den Oord committed 2013-05-31 20:26:35 +02:00
1 parent aeb8c878d0
commit 248c53b445
2 files changed
+42 -60
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

Tennis/objc/TennisTests/TennisTests.m
+27 -38
View File
@@ -12,24 +12,41 @@
#import "TennisGame2.h"
#import "TennisGame3.h"
@implementation TennisTests {
int player1Score;
int player2Score;
NSString *expectedScore;
}
@interface TennisTests (Parametrized)
+ (NSArray*)parameters;
@end
@implementation TennisTests (Parametrized)
+ (id)defaultTestSuite {
SenTestSuite *testSuite = [[SenTestSuite alloc] initWithName:NSStringFromClass(self)];
NSArray *allScores = [self allScores];
NSArray *allScores = [self parameters];
for (NSArray *scores in allScores) {
[self addTestWithScores:scores toTestSuite:testSuite];
}
return testSuite;
}
+ (void)addTestWithScores:(NSArray *)scores toTestSuite:(SenTestSuite *)testSuite {
NSArray *testInvocations = [self testInvocations];
for (NSInvocation *testInvocation in testInvocations) {
+ (NSArray*)allScores {
// Create a new instance of our test case for each method found using the given set of parameters.
SenTestCase *test = [[TennisTests alloc] initWithInvocation:testInvocation
scores:scores];
// Add the new test instance to the suite. The OCUnit framework eventually executes the entire test suite.
[testSuite addTest:test];
}
}
@end
@implementation TennisTests {
int player1Score;
int player2Score;
NSString *expectedScore;
}
+ (NSArray*)parameters {
return @[
@[ @0, @0, @"Love-All"],
@[ @1, @1, @"Fifteen-All"],
@@ -72,24 +89,6 @@
];
}
+ (void)addTestWithScores:(NSArray *)scores toTestSuite:(SenTestSuite *)testSuite {
NSArray *testInvocations = [self testInvocations];
for (NSInvocation *testInvocation in testInvocations) {
// Create a new instance of our test case for each method found using the given set of parameters.
SenTestCase *test = [[TennisTests alloc] initWithInvocation:testInvocation
scores:scores];
// Add the new test instance to the suite. The OCUnit framework eventually executes the entire test suite.
[testSuite addTest:test];
}
}
- (NSString *)name {
return [NSString stringWithFormat:@"%@ (%d,%d,%@)", [super name], player1Score, player2Score, expectedScore];
}
- (id)initWithInvocation:(NSInvocation *)invocation scores:(NSArray *)scores {
self = [super initWithInvocation:invocation];
if (self) {
@@ -100,18 +99,8 @@
return self;
}
- (void)setUp
{
[super setUp];
// Set-up code here.
}
- (void)tearDown
{
// Tear-down code here.
[super tearDown];
- (NSString *)name {
return [NSString stringWithFormat:@"%@ (%d,%d,%@)", [super name], player1Score, player2Score, expectedScore];
}
- (void)checkAllScoresForGame:(TennisGame *)game {