OpenSource/GildedRose-Refactoring-Kata
1
0
Fork 0
mirror of https://github.com/emilybache/GildedRose-Refactoring-Kata.git synced 2026-02-09 19:51:41 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Remove redundant if/when

Browse Source
This commit is contained in:
Denys 2025-05-11 18:44:08 +12:00
parent c3c409a500
commit 2537f5c844
1 changed files with 22 additions and 36 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

58
Kotlin/src/main/kotlin/com/gildedrose/GildedRose.kt
View File

@ -6,48 +6,35 @@ class GildedRose(var items: List<Item>) {
fun updateQuality() { fun updateQuality() {
for (i in items.indices) { for (i in items.indices) {
if ( if (items[i].name == "Backstage passes to a TAFKAL80ETC concert") {
items[i].name != "Aged Brie" &&
items[i].name != "Backstage passes to a TAFKAL80ETC concert" &&
items[i].name != "Sulfuras, Hand of Ragnaros"
) {
downGradeQuality(i)
} else {
upgradeQuality(i) upgradeQuality(i)
when {
if (items[i].name == "Backstage passes to a TAFKAL80ETC concert") { items[i].sellIn < 1 -> {
when {
items[i].sellIn < 6 -> {
upgradeQuality(i)
upgradeQuality(i)
}
items[i].sellIn < 11 -> {
upgradeQuality(i)
}
}
}
}
sellItem(i)
if (items[i].sellIn < 0) {
when (items[i].name) {
"Aged Brie" -> {
upgradeQuality(i)
}
"Backstage passes to a TAFKAL80ETC concert" -> {
items[i].quality -= items[i].quality items[i].quality -= items[i].quality
} }
else -> { items[i].sellIn < 6 -> {
if (items[i].name != "Sulfuras, Hand of Ragnaros") { upgradeQuality(i)
downGradeQuality(i) upgradeQuality(i)
} }
items[i].sellIn < 11 -> {
upgradeQuality(i)
} }
} }
} else if (items[i].name == "Aged Brie") {
upgradeQuality(i)
if (items[i].sellIn < 1) {
upgradeQuality(i)
}
} else if (items[i].name == "Sulfuras, Hand of Ragnaros") {
upgradeQuality(i)
} else {
downGradeQuality(i)
if (items[i].sellIn < 1) downGradeQuality(i)
} }
sellItem(i)
} }
} }
@ -61,7 +48,6 @@ class GildedRose(var items: List<Item>) {
private fun upgradeQuality(i: Int) { private fun upgradeQuality(i: Int) {
if (items[i].quality < 50) items[i].quality += 1 if (items[i].quality < 50) items[i].quality += 1
} }
} }