OpenSource/GildedRose-Refactoring-Kata
1
0
Fork 0
mirror of https://github.com/emilybache/GildedRose-Refactoring-Kata.git synced 2026-02-10 12:11:20 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

feature!: Unknown should be Normal

Browse Source
This commit is contained in:
Kadir Sirimsi 2025-02-10 16:48:09 +01:00
parent 8d3c6ebcee
commit 254d42fa1a
No known key found for this signature in database
GPG Key ID: A21C0144C2D2A134
3 changed files with 7 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Java/src/main/java/com/gildedrose/Item.java
View File

@ -30,7 +30,7 @@ public class Item {
case AgedBrie -> updateAgedBrieItem(); case AgedBrie -> updateAgedBrieItem();
case BackstagePass -> updateBackstagePassItem(); case BackstagePass -> updateBackstagePassItem();
case Sulfuras -> {} case Sulfuras -> {}
case Unknown -> updateUnknownItem(); case Normal -> updateUnknownItem();
} }
} }

4
Java/src/main/java/com/gildedrose/ItemType.java
View File

@ -6,7 +6,7 @@ public enum ItemType {
AgedBrie("Aged Brie"), AgedBrie("Aged Brie"),
BackstagePass("Backstage passes to a TAFKAL80ETC concert"), BackstagePass("Backstage passes to a TAFKAL80ETC concert"),
Sulfuras("Sulfuras, Hand of Ragnaros"), Sulfuras("Sulfuras, Hand of Ragnaros"),
Unknown("Unknown"); Normal("Normal");
private final String name; private final String name;
@ -22,6 +22,6 @@ public enum ItemType {
return Arrays.stream(ItemType.values()) return Arrays.stream(ItemType.values())
.filter(itemType -> itemType.getName().equals(name)) .filter(itemType -> itemType.getName().equals(name))
.findFirst() .findFirst()
.orElse(Unknown); .orElse(Normal);
} }
} }

9
Java/src/test/java/com/gildedrose/ItemTest.java
View File

@ -1,6 +1,5 @@
package com.gildedrose; package com.gildedrose;
import org.junit.jupiter.api.Assertions;
import org.junit.jupiter.params.ParameterizedTest; import org.junit.jupiter.params.ParameterizedTest;
import org.junit.jupiter.params.provider.Arguments; import org.junit.jupiter.params.provider.Arguments;
import org.junit.jupiter.params.provider.MethodSource; import org.junit.jupiter.params.provider.MethodSource;
@ -10,7 +9,7 @@ import java.util.stream.Stream;
import static com.gildedrose.ItemType.AgedBrie; import static com.gildedrose.ItemType.AgedBrie;
import static com.gildedrose.ItemType.BackstagePass; import static com.gildedrose.ItemType.BackstagePass;
import static com.gildedrose.ItemType.Sulfuras; import static com.gildedrose.ItemType.Sulfuras;
import static com.gildedrose.ItemType.Unknown; import static com.gildedrose.ItemType.Normal;
import static org.junit.jupiter.api.Assertions.assertEquals; import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.params.provider.Arguments.of; import static org.junit.jupiter.params.provider.Arguments.of;
@ -51,9 +50,9 @@ class ItemTest {
of(new Item(BackstagePass.getName(), -1, 40), new Item(BackstagePass.getName(), -11, 0), 10), of(new Item(BackstagePass.getName(), -1, 40), new Item(BackstagePass.getName(), -11, 0), 10),
// Other // Other
of(new Item(Unknown.getName(), 0, 40), new Item(Unknown.getName(), -10, 20), 10), of(new Item(Normal.getName(), 0, 40), new Item(Normal.getName(), -10, 20), 10),
of(new Item(Unknown.getName(), -1, 40), new Item(Unknown.getName(), -11, 20), 10), of(new Item(Normal.getName(), -1, 40), new Item(Normal.getName(), -11, 20), 10),
of(new Item(Unknown.getName(), -5, 80), new Item(Unknown.getName(), -25, 40), 20) of(new Item(Normal.getName(), -5, 80), new Item(Normal.getName(), -25, 40), 20)
); );
} }