From 268c2752819ed4bd5b60f8192c876f3934a9b357 Mon Sep 17 00:00:00 2001
From: robbertvdzon <robbert.vanderzon@wearetriple.com>
Date: Sun, 8 May 2022 09:49:48 +0200
Subject: [PATCH] adding first set of tests: fix bug in BaseTest

---
 .../com/gildedrose/GildedRoseBaseTest.kt      | 24 +++++++++----------
 1 file changed, 11 insertions(+), 13 deletions(-)

diff --git a/Kotlin/src/test/kotlin/com/gildedrose/GildedRoseBaseTest.kt b/Kotlin/src/test/kotlin/com/gildedrose/GildedRoseBaseTest.kt
index 8ba49e77..ebb2569f 100644
--- a/Kotlin/src/test/kotlin/com/gildedrose/GildedRoseBaseTest.kt
+++ b/Kotlin/src/test/kotlin/com/gildedrose/GildedRoseBaseTest.kt
@@ -20,7 +20,16 @@ abstract class GildedRoseBaseTest {
         resultingSellIn: Int,
         resultingQuality: Int
     ) {
-        testGildedRose(name, initialSellIn, initialQuality, numberDays, resultingSellIn, resultingQuality)
+        val item = Item(name, initialSellIn, initialQuality)
+        val items = arrayOf(item)
+        val app = GildedRose(items)
+
+        (1..numberDays).forEach { _ ->
+            app.updateQuality()
+        }
+        Assertions.assertThat(item.name).isEqualTo(name)
+        Assertions.assertThat(item.sellIn).isEqualTo(resultingSellIn)
+        Assertions.assertThat(item.quality).isEqualTo(resultingQuality)
     }
 
     @ParameterizedTest(name = "{0}: initial sellIn:{1} and initial quality:{2}, after {3} days: sellIn:{4} and quality {5}, using Refactored algorithm")
@@ -32,21 +41,10 @@ abstract class GildedRoseBaseTest {
         numberDays: Int,
         resultingSellIn: Int,
         resultingQuality: Int
-    ) {
-        testGildedRose(name, initialSellIn, initialQuality, numberDays, resultingSellIn, resultingQuality)
-    }
-
-    private fun testGildedRose(
-        name: String,
-        initialSellIn: Int,
-        initialQuality: Int,
-        numberDays: Int,
-        resultingSellIn: Int,
-        resultingQuality: Int
     ) {
         val item = Item(name, initialSellIn, initialQuality)
         val items = arrayOf(item)
-        val app = GildedRose(items)
+        val app = GildedRoseLegacy(items)
 
         (1..numberDays).forEach { _ ->
             app.updateQuality()