OpenSource/GildedRose-Refactoring-Kata
1
0
Fork 0
mirror of https://github.com/emilybache/GildedRose-Refactoring-Kata.git synced 2026-02-10 12:11:20 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

2. Extracted monolithic update_quality into focused methods

Browse Source
This commit is contained in:
Yarramsetti Naresh 2025-04-06 17:41:49 +05:30
parent 5d1bb3cee1
commit 273ed6aa7c
1 changed files with 43 additions and 27 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

70
python/gilded_rose.py
View File

@ -1,40 +1,56 @@
# -*- coding: utf-8 -*- # -*- coding: utf-8 -*-
class GildedRose(object): class GildedRose(object):
def __init__(self, items): def __init__(self, items):
self.items = items self.items = items
def update_quality(self): def update_quality(self):
for item in self.items: for item in self.items:
if item.name != "Aged Brie" and item.name != "Backstage passes to a TAFKAL80ETC concert": self.update_item_quality(item)
if item.quality > 0: self.update_sell_in(item)
if item.name != "Sulfuras, Hand of Ragnaros":
item.quality = item.quality - 1
else:
if item.quality < 50:
item.quality = item.quality + 1
if item.name == "Backstage passes to a TAFKAL80ETC concert":
if item.sell_in < 11:
if item.quality < 50:
item.quality = item.quality + 1
if item.sell_in < 6:
if item.quality < 50:
item.quality = item.quality + 1
if item.name != "Sulfuras, Hand of Ragnaros":
item.sell_in = item.sell_in - 1
if item.sell_in < 0: if item.sell_in < 0:
if item.name != "Aged Brie": self.handle_expired_item(item)
if item.name != "Backstage passes to a TAFKAL80ETC concert":
if item.quality > 0:
if item.name != "Sulfuras, Hand of Ragnaros":
item.quality = item.quality - 1
else:
item.quality = item.quality - item.quality
else:
if item.quality < 50:
item.quality = item.quality + 1
def update_item_quality(self, item):
if item.name == "Aged Brie":
self.update_aged_brie(item)
elif item.name == "Backstage passes to a TAFKAL80ETC concert":
self.update_backstage_pass(item)
elif item.name != "Sulfuras, Hand of Ragnaros":
self.update_normal_item(item)
def update_sell_in(self, item):
if item.name != "Sulfuras, Hand of Ragnaros":
item.sell_in -= 1
def handle_expired_item(self, item):
if item.name == "Aged Brie":
self.increase_quality(item)
elif item.name == "Backstage passes to a TAFKAL80ETC concert":
item.quality = 0
elif item.name != "Sulfuras, Hand of Ragnaros":
self.decrease_quality(item)
def update_aged_brie(self, item):
self.increase_quality(item)
def update_backstage_pass(self, item):
self.increase_quality(item)
if item.sell_in < 11:
self.increase_quality(item)
if item.sell_in < 6:
self.increase_quality(item)
def update_normal_item(self, item):
self.decrease_quality(item)
def increase_quality(self, item):
if item.quality < 50:
item.quality += 1
def decrease_quality(self, item):
if item.quality > 0:
item.quality -= 1
class Item: class Item:
def __init__(self, name, sell_in, quality): def __init__(self, name, sell_in, quality):