OpenSource/GildedRose-Refactoring-Kata
1
0
Fork 0
mirror of https://github.com/emilybache/GildedRose-Refactoring-Kata.git synced 2026-02-04 09:11:39 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Refactor GiledRose to use GildedItem hierarchy

Browse Source
This commit is contained in:
Yossri Ghabri 2025-11-25 15:49:57 +01:00
parent 35381e1864
commit 27b90d1d41
1 changed files with 12 additions and 48 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

60
Java/src/main/java/com/gildedrose/GildedRose.java
View File

@ -1,5 +1,7 @@
package com.gildedrose; package com.gildedrose;
import com.gildedrose.items.*;
class GildedRose { class GildedRose {
Item[] items; Item[] items;
@ -9,54 +11,16 @@ class GildedRose {
public void updateQuality() { public void updateQuality() {
for (int i = 0; i < items.length; i++) { for (int i = 0; i < items.length; i++) {
if (!items[i].name.equals("Aged Brie") GildedItem gi = toGildedItem(items[i]);
&& !items[i].name.equals("Backstage passes to a TAFKAL80ETC concert")) { gi.updateQuality();
if (items[i].quality > 0) {
if (!items[i].name.equals("Sulfuras, Hand of Ragnaros")) {
items[i].quality = items[i].quality - 1;
}
}
} else {
if (items[i].quality < 50) {
items[i].quality = items[i].quality + 1;
if (items[i].name.equals("Backstage passes to a TAFKAL80ETC concert")) {
if (items[i].sellIn < 11) {
if (items[i].quality < 50) {
items[i].quality = items[i].quality + 1;
}
}
if (items[i].sellIn < 6) {
if (items[i].quality < 50) {
items[i].quality = items[i].quality + 1;
}
}
}
}
}
if (!items[i].name.equals("Sulfuras, Hand of Ragnaros")) {
items[i].sellIn = items[i].sellIn - 1;
}
if (items[i].sellIn < 0) {
if (!items[i].name.equals("Aged Brie")) {
if (!items[i].name.equals("Backstage passes to a TAFKAL80ETC concert")) {
if (items[i].quality > 0) {
if (!items[i].name.equals("Sulfuras, Hand of Ragnaros")) {
items[i].quality = items[i].quality - 1;
}
}
} else {
items[i].quality = items[i].quality - items[i].quality;
}
} else {
if (items[i].quality < 50) {
items[i].quality = items[i].quality + 1;
}
}
}
} }
} }
private GildedItem toGildedItem(Item item) {
if (ItemUtils.isAgedBrie(item)) return new AgedBrieItem(item);
if (ItemUtils.isBackstage(item)) return new BackstageItem(item);
if (ItemUtils.isSulfuras(item)) return new SulfurasItem(item);
// this conjured item does not work properly yet
return new NormalItem(item);
}
} }