OpenSource/GildedRose-Refactoring-Kata
1
0
Fork 0
mirror of https://github.com/emilybache/GildedRose-Refactoring-Kata.git synced 2026-02-04 09:11:39 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

rename, and add final for static string variables

Browse Source
This commit is contained in:
Karim Fadel 2026-01-14 07:18:48 +02:00
parent a2879d203a
commit 287daf6e0d
1 changed files with 11 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
Java-Approvals/src/main/java/com/gildedrose/GildedRose.java
View File

@ -1,9 +1,10 @@
package com.gildedrose; package com.gildedrose;
class GildedRose { class GildedRose {
private static String AGED_BRIE = "Aged Brie"; private final static String AGED_BRIE = "Aged Brie";
private static String BACKSTAGE_PASSES = "Backstage passes to a TAFKAL80ETC concert"; private final static String BACKSTAGE_PASSES = "Backstage passes to a TAFKAL80ETC concert";
private static String SULFURAS = "Sulfuras, Hand of Ragnaros"; private final static String SULFURAS = "Sulfuras, Hand of Ragnaros";
Item[] items; Item[] items;
public GildedRose(Item[] items) { public GildedRose(Item[] items) {
@ -13,14 +14,14 @@ class GildedRose {
public void updateQuality() { public void updateQuality() {
for (int i = 0; i < items.length; i++) { for (int i = 0; i < items.length; i++) {
if (items[i].name.equals(AGED_BRIE)) { if (items[i].name.equals(AGED_BRIE)) {
incrementQualityByOne(i); increaseQualityByOne(i);
} else if (items[i].name.equals(BACKSTAGE_PASSES)) { } else if (items[i].name.equals(BACKSTAGE_PASSES)) {
if (items[i].sellIn < 6) { if (items[i].sellIn < 6) {
increaseQualityByThree(i); increaseQualityByThree(i);
} else if (items[i].sellIn < 11) { } else if (items[i].sellIn < 11) {
increaseQualityByTwo(i); increaseQualityByTwo(i);
} else { } else {
incrementQualityByOne(i); increaseQualityByOne(i);
} }
} else { } else {
decreaseQualityByOne(i); decreaseQualityByOne(i);
@ -32,7 +33,7 @@ class GildedRose {
if (items[i].sellIn < 0) { if (items[i].sellIn < 0) {
if (items[i].name.equals(AGED_BRIE)) { if (items[i].name.equals(AGED_BRIE)) {
incrementQualityByOne(i); increaseQualityByOne(i);
} else { } else {
if (items[i].name.equals(BACKSTAGE_PASSES)) { if (items[i].name.equals(BACKSTAGE_PASSES)) {
items[i].quality = 0; items[i].quality = 0;
@ -46,12 +47,12 @@ class GildedRose {
private void increaseQualityByThree(int i) { private void increaseQualityByThree(int i) {
increaseQualityByTwo(i); increaseQualityByTwo(i);
incrementQualityByOne(i); increaseQualityByOne(i);
} }
private void increaseQualityByTwo(int i) { private void increaseQualityByTwo(int i) {
incrementQualityByOne(i); increaseQualityByOne(i);
incrementQualityByOne(i); increaseQualityByOne(i);
} }
private void decreaseQualityByOne(int i) { private void decreaseQualityByOne(int i) {
@ -62,7 +63,7 @@ class GildedRose {
} }
} }
private void incrementQualityByOne(int i) { private void increaseQualityByOne(int i) {
if (items[i].quality < 50) { if (items[i].quality < 50) {
items[i].quality = items[i].quality + 1; items[i].quality = items[i].quality + 1;
} }