OpenSource/GildedRose-Refactoring-Kata
1
0
Fork 0
mirror of https://github.com/emilybache/GildedRose-Refactoring-Kata.git synced 2025-12-12 12:22:12 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Remove quality change on sulfuras

Browse Source 
For some reason the php7 version sets the quality of sulfuras to be 80.
The sepcification simply states this is the max, and that it does not change, as 
written on line 22 of the english specifications.
This commit is contained in:
Gert de Pagter 2020-01-15 15:27:50 +01:00 committed by GitHub
parent 9a9b4351f2
commit 2a4f2b3b7c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 0 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
php7/src/GildedRose.php
View File

@ -16,8 +16,6 @@ final class GildedRose {
if ($item->quality > 0) { if ($item->quality > 0) {
if ($item->name != 'Sulfuras, Hand of Ragnaros') { if ($item->name != 'Sulfuras, Hand of Ragnaros') {
$item->quality = $item->quality - 1; $item->quality = $item->quality - 1;
} else {
$item->quality = 80;
} }
} }
} else { } else {