OpenSource/GildedRose-Refactoring-Kata
1
0
Fork 0
mirror of https://github.com/emilybache/GildedRose-Refactoring-Kata.git synced 2026-02-18 16:01:42 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Refactor: sepereate handleQualitySellInIs0

Browse Source 
- use switch case
This commit is contained in:
Gayun00 2023-09-25 17:25:39 +09:00
parent 16d0d0c5a0
commit 2bacc188d5
1 changed files with 29 additions and 27 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

56
TypeScript/app/gilded-rose.ts
View File

@ -19,51 +19,53 @@ export class GildedRose {
this.items = items; this.items = items;
} }
handleIfSellInIs0(item) {
if (item.sellIn >= 0) return;
switch (item.name) {
case ITEMS.BRIE:
if (item.quality >= 50) return;
item.quality = item.quality + 1;
break;
case ITEMS.SURFRAS:
item.quality = item.quality - item.quality;
break;
default:
if (!item.quality) return;
item.quality -= 1;
break;
}
}
updateQuality() { updateQuality() {
for (const item of this.items) { for (const item of this.items) {
if (item.name != ITEMS.BRIE && item.name != ITEMS.PASSES) { if (item.name != ITEMS.BRIE && item.name != ITEMS.PASSES) {
if (item.quality > 0) { if (!item.quality) break;
if (item.name != ITEMS.SURFRAS) { if (item.name != ITEMS.SURFRAS) {
item.quality = item.quality - 1; item.quality -= 1;
}
} }
} else { } else {
if (item.quality < 50) { if (item.quality < 50) {
item.quality = item.quality + 1; item.quality += 1;
if (item.name == ITEMS.PASSES) { if (item.name == ITEMS.PASSES) {
if (item.sellIn < 11) { if (item.sellIn < 11) {
if (item.quality < 50) { if (item.quality < 50) {
item.quality = item.quality + 1; item.quality += 1;
} }
} }
if (item.sellIn < 6) { if (item.sellIn < 6) {
if (item.quality < 50) { if (item.quality >= 50) break;
item.quality = item.quality + 1; item.quality += 1;
}
} }
} }
} }
} }
if (item.name != ITEMS.SURFRAS) { if (item.name != ITEMS.SURFRAS) {
item.sellIn = item.sellIn - 1; item.sellIn -= 1;
}
if (item.sellIn < 0) {
if (item.name != ITEMS.BRIE) {
if (item.name != ITEMS.PASSES) {
if (item.quality > 0) {
if (item.name != ITEMS.SURFRAS) {
item.quality = item.quality - 1;
}
}
} else {
item.quality = item.quality - item.quality;
}
} else {
if (item.quality < 50) {
item.quality = item.quality + 1;
}
}
} }
this.handleIfSellInIs0(item);
} }
return this.items; return this.items;