OpenSource/GildedRose-Refactoring-Kata
1
0
Fork 0
mirror of https://github.com/emilybache/GildedRose-Refactoring-Kata.git synced 2026-02-17 23:41:27 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Flatten conditionals in sellInBelow0

Browse Source
This commit is contained in:
Jesper 2022-04-13 16:31:16 +02:00
parent e734b35f3a
commit 2cd5a72201
2 changed files with 15 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
TypeScript/app/gilded-rose.ts
View File

@ -54,20 +54,23 @@ export class GildedRose {
} }
private sellInBelow0(item: Item) { private sellInBelow0(item: Item) {
if (item.name != 'Aged Brie') { if (item.name == 'Sulfuras, Hand of Ragnaros') return
if (item.name != 'Backstage passes to a TAFKAL80ETC concert') {
if (item.quality > 0) { if (item.name == 'Aged Brie') {
if (item.name != 'Sulfuras, Hand of Ragnaros') {
item.quality = item.quality - 1;
}
}
} else {
item.quality = item.quality - item.quality;
}
} else {
if (item.quality < 50) { if (item.quality < 50) {
item.quality = item.quality + 1; item.quality = item.quality + 1;
} }
return
}
if (item.name == 'Backstage passes to a TAFKAL80ETC concert') {
item.quality = item.quality - item.quality;
return
}
if (item.quality > 0) {
item.quality = item.quality - 1;
return
} }
} }
} }

2
TypeScript/test/jest/gilded-rose.spec.ts
View File

@ -62,7 +62,7 @@ export class AcceptanceGildedRose {
} }
test('acceptance tests', () => { test('acceptance tests', () => {
const names = ['Aged Brie', 'Backstage passes to a TAFKAL80ETC concert', 'Sulfuras, Hand of Ragnaros'] const names = ['Aged Brie', 'Backstage passes to a TAFKAL80ETC concert', 'Sulfuras, Hand of Ragnaros', 'Other']
const sellIns = [-1, 0, 1, 2, 5, 6, 7, 10, 11, 12, 13, 14, 15] const sellIns = [-1, 0, 1, 2, 5, 6, 7, 10, 11, 12, 13, 14, 15]
const qualities = [-1, 1, 2, 48, 49, 50, 51] const qualities = [-1, 1, 2, 48, 49, 50, 51]