Merge pull request #498 from codecop/master

Approval tests starting points for PHP and TS/Jest.

TypeScript/.gitignore

@@ -8,3 +8,4 @@ test/**/*.js
 test/**/*.js.map
 coverage
 .nyc_output
+package-lock.json

TypeScript/test/jest/approvals.spec.ts

@@ -0,0 +1,54 @@
+import { Item, GildedRose } from '@/gilded-rose';
+
+/**
+ * This unit test uses [Jest Snapshot](https://goo.gl/fbAQLP).
+ * 
+ * There are two test cases here with different styles:
+ * <li>"foo" is more similar to the unit test from the 'Java' version
+ * <li>"thirtyDays" is more similar to the TextTest from the 'Java' version
+ *
+ * I suggest choosing one style to develop and deleting the other.
+ */
+
+describe('Gilded Rose Approval', () => {
+
+  let gameConsoleOutput: string;
+  let originalConsoleLog: (message: any) => void;
+  let originalProcessArgv: string[]
+
+  function gameConsoleLog(msg: string) {
+    if (msg) {
+      gameConsoleOutput += msg;
+    }
+    gameConsoleOutput += "\n";
+  }
+
+  beforeEach(() => {
+    // prepare capturing console.log to our own gameConsoleLog.
+    gameConsoleOutput = "";
+    originalConsoleLog = console.log;
+    console.log = gameConsoleLog;
+    originalProcessArgv = process.argv;
+  });
+
+  afterEach(() => {
+    // reset original console.log
+    console.log = originalConsoleLog;
+    process.argv = originalProcessArgv;
+  });
+
+  it('should foo', () => {
+    const gildedRose = new GildedRose([new Item('foo', 0, 0)]);
+    const items = gildedRose.updateQuality();
+  
+    expect(items).toMatchSnapshot();
+  });
+
+  it('should thirtyDays', () => {
+    process.argv = ["<node>", "<script", "30"];
+    require('../golden-master-text-test.ts');
+       
+    expect(gameConsoleOutput).toMatchSnapshot();
+  });
+
+});

TypeScript/tsconfig.json

@@ -4,7 +4,7 @@
     "target": "es5",
     "strict": true,
     "noImplicitAny": false,
-    "sourceMap": false,
+    "sourceMap": true,
     "baseUrl": "./",
     "resolveJsonModule": true,
     "esModuleInterop": true,

php/fixtures/texttest_fixture.php

@@ -30,7 +30,7 @@ if ((is_countable($argv) ? count($argv) : 0) > 1) {
 }
 
 for ($i = 0; $i < $days; $i++) {
-    echo "-------- day ${i} --------" . PHP_EOL;
+    echo "-------- day {$i} --------" . PHP_EOL;
     echo 'name, sellIn, quality' . PHP_EOL;
     foreach ($items as $item) {
         echo $item . PHP_EOL;

php/tests/ApprovalTest.php

@@ -0,0 +1,44 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Tests;
+
+use GildedRose\GildedRose;
+use GildedRose\Item;
+use PHPUnit\Framework\TestCase;
+use ApprovalTests\Approvals;
+
+/**
+ * This unit test uses [Approvals](https://github.com/approvals/ApprovalTests.php).
+ * 
+ * There are two test cases here with different styles:
+ * <li>"foo" is more similar to the unit test from the 'Java' version
+ * <li>"thirtyDays" is more similar to the TextTest from the 'Java' version
+ *
+ * I suggest choosing one style to develop and deleting the other.
+ */
+class ApprovalTest extends TestCase
+{
+
+	public function testFoo(): void
+    {
+        $items = [new Item('foo', 0, 0)];
+        $app = new GildedRose($items);
+        $app->updateQuality();
+
+		Approvals::verifyList($items);
+	}
+
+    public function testThirtyDays(): void
+     {
+        ob_start();
+
+        $argv = ["", "30"];
+        include(__DIR__.'/../fixtures/texttest_fixture.php');
+        
+        $output = ob_get_clean();
+
+        Approvals::approveString($output);
+    }
+}

php/tests/approvals/ApprovalTest.testTestFixture.approved.txt

@@ -1,373 +0,0 @@
-OMGHAI!
--------- day 0 --------
-name, sellIn, quality
-+5 Dexterity Vest, 10, 20
-Aged Brie, 2, 0
-Elixir of the Mongoose, 5, 7
-Sulfuras, Hand of Ragnaros, 0, 80
-Sulfuras, Hand of Ragnaros, -1, 80
-Backstage passes to a TAFKAL80ETC concert, 15, 20
-Backstage passes to a TAFKAL80ETC concert, 10, 49
-Backstage passes to a TAFKAL80ETC concert, 5, 49
-Conjured Mana Cake, 3, 6
-
--------- day 1 --------
-name, sellIn, quality
-+5 Dexterity Vest, 9, 19
-Aged Brie, 1, 1
-Elixir of the Mongoose, 4, 6
-Sulfuras, Hand of Ragnaros, 0, 80
-Sulfuras, Hand of Ragnaros, -1, 80
-Backstage passes to a TAFKAL80ETC concert, 14, 21
-Backstage passes to a TAFKAL80ETC concert, 9, 50
-Backstage passes to a TAFKAL80ETC concert, 4, 50
-Conjured Mana Cake, 2, 5
-
--------- day 2 --------
-name, sellIn, quality
-+5 Dexterity Vest, 8, 18
-Aged Brie, 0, 2
-Elixir of the Mongoose, 3, 5
-Sulfuras, Hand of Ragnaros, 0, 80
-Sulfuras, Hand of Ragnaros, -1, 80
-Backstage passes to a TAFKAL80ETC concert, 13, 22
-Backstage passes to a TAFKAL80ETC concert, 8, 50
-Backstage passes to a TAFKAL80ETC concert, 3, 50
-Conjured Mana Cake, 1, 4
-
--------- day 3 --------
-name, sellIn, quality
-+5 Dexterity Vest, 7, 17
-Aged Brie, -1, 4
-Elixir of the Mongoose, 2, 4
-Sulfuras, Hand of Ragnaros, 0, 80
-Sulfuras, Hand of Ragnaros, -1, 80
-Backstage passes to a TAFKAL80ETC concert, 12, 23
-Backstage passes to a TAFKAL80ETC concert, 7, 50
-Backstage passes to a TAFKAL80ETC concert, 2, 50
-Conjured Mana Cake, 0, 3
-
--------- day 4 --------
-name, sellIn, quality
-+5 Dexterity Vest, 6, 16
-Aged Brie, -2, 6
-Elixir of the Mongoose, 1, 3
-Sulfuras, Hand of Ragnaros, 0, 80
-Sulfuras, Hand of Ragnaros, -1, 80
-Backstage passes to a TAFKAL80ETC concert, 11, 24
-Backstage passes to a TAFKAL80ETC concert, 6, 50
-Backstage passes to a TAFKAL80ETC concert, 1, 50
-Conjured Mana Cake, -1, 1
-
--------- day 5 --------
-name, sellIn, quality
-+5 Dexterity Vest, 5, 15
-Aged Brie, -3, 8
-Elixir of the Mongoose, 0, 2
-Sulfuras, Hand of Ragnaros, 0, 80
-Sulfuras, Hand of Ragnaros, -1, 80
-Backstage passes to a TAFKAL80ETC concert, 10, 25
-Backstage passes to a TAFKAL80ETC concert, 5, 50
-Backstage passes to a TAFKAL80ETC concert, 0, 50
-Conjured Mana Cake, -2, 0
-
--------- day 6 --------
-name, sellIn, quality
-+5 Dexterity Vest, 4, 14
-Aged Brie, -4, 10
-Elixir of the Mongoose, -1, 0
-Sulfuras, Hand of Ragnaros, 0, 80
-Sulfuras, Hand of Ragnaros, -1, 80
-Backstage passes to a TAFKAL80ETC concert, 9, 27
-Backstage passes to a TAFKAL80ETC concert, 4, 50
-Backstage passes to a TAFKAL80ETC concert, -1, 0
-Conjured Mana Cake, -3, 0
-
--------- day 7 --------
-name, sellIn, quality
-+5 Dexterity Vest, 3, 13
-Aged Brie, -5, 12
-Elixir of the Mongoose, -2, 0
-Sulfuras, Hand of Ragnaros, 0, 80
-Sulfuras, Hand of Ragnaros, -1, 80
-Backstage passes to a TAFKAL80ETC concert, 8, 29
-Backstage passes to a TAFKAL80ETC concert, 3, 50
-Backstage passes to a TAFKAL80ETC concert, -2, 0
-Conjured Mana Cake, -4, 0
-
--------- day 8 --------
-name, sellIn, quality
-+5 Dexterity Vest, 2, 12
-Aged Brie, -6, 14
-Elixir of the Mongoose, -3, 0
-Sulfuras, Hand of Ragnaros, 0, 80
-Sulfuras, Hand of Ragnaros, -1, 80
-Backstage passes to a TAFKAL80ETC concert, 7, 31
-Backstage passes to a TAFKAL80ETC concert, 2, 50
-Backstage passes to a TAFKAL80ETC concert, -3, 0
-Conjured Mana Cake, -5, 0
-
--------- day 9 --------
-name, sellIn, quality
-+5 Dexterity Vest, 1, 11
-Aged Brie, -7, 16
-Elixir of the Mongoose, -4, 0
-Sulfuras, Hand of Ragnaros, 0, 80
-Sulfuras, Hand of Ragnaros, -1, 80
-Backstage passes to a TAFKAL80ETC concert, 6, 33
-Backstage passes to a TAFKAL80ETC concert, 1, 50
-Backstage passes to a TAFKAL80ETC concert, -4, 0
-Conjured Mana Cake, -6, 0
-
--------- day 10 --------
-name, sellIn, quality
-+5 Dexterity Vest, 0, 10
-Aged Brie, -8, 18
-Elixir of the Mongoose, -5, 0
-Sulfuras, Hand of Ragnaros, 0, 80
-Sulfuras, Hand of Ragnaros, -1, 80
-Backstage passes to a TAFKAL80ETC concert, 5, 35
-Backstage passes to a TAFKAL80ETC concert, 0, 50
-Backstage passes to a TAFKAL80ETC concert, -5, 0
-Conjured Mana Cake, -7, 0
-
--------- day 11 --------
-name, sellIn, quality
-+5 Dexterity Vest, -1, 8
-Aged Brie, -9, 20
-Elixir of the Mongoose, -6, 0
-Sulfuras, Hand of Ragnaros, 0, 80
-Sulfuras, Hand of Ragnaros, -1, 80
-Backstage passes to a TAFKAL80ETC concert, 4, 38
-Backstage passes to a TAFKAL80ETC concert, -1, 0
-Backstage passes to a TAFKAL80ETC concert, -6, 0
-Conjured Mana Cake, -8, 0
-
--------- day 12 --------
-name, sellIn, quality
-+5 Dexterity Vest, -2, 6
-Aged Brie, -10, 22
-Elixir of the Mongoose, -7, 0
-Sulfuras, Hand of Ragnaros, 0, 80
-Sulfuras, Hand of Ragnaros, -1, 80
-Backstage passes to a TAFKAL80ETC concert, 3, 41
-Backstage passes to a TAFKAL80ETC concert, -2, 0
-Backstage passes to a TAFKAL80ETC concert, -7, 0
-Conjured Mana Cake, -9, 0
-
--------- day 13 --------
-name, sellIn, quality
-+5 Dexterity Vest, -3, 4
-Aged Brie, -11, 24
-Elixir of the Mongoose, -8, 0
-Sulfuras, Hand of Ragnaros, 0, 80
-Sulfuras, Hand of Ragnaros, -1, 80
-Backstage passes to a TAFKAL80ETC concert, 2, 44
-Backstage passes to a TAFKAL80ETC concert, -3, 0
-Backstage passes to a TAFKAL80ETC concert, -8, 0
-Conjured Mana Cake, -10, 0
-
--------- day 14 --------
-name, sellIn, quality
-+5 Dexterity Vest, -4, 2
-Aged Brie, -12, 26
-Elixir of the Mongoose, -9, 0
-Sulfuras, Hand of Ragnaros, 0, 80
-Sulfuras, Hand of Ragnaros, -1, 80
-Backstage passes to a TAFKAL80ETC concert, 1, 47
-Backstage passes to a TAFKAL80ETC concert, -4, 0
-Backstage passes to a TAFKAL80ETC concert, -9, 0
-Conjured Mana Cake, -11, 0
-
--------- day 15 --------
-name, sellIn, quality
-+5 Dexterity Vest, -5, 0
-Aged Brie, -13, 28
-Elixir of the Mongoose, -10, 0
-Sulfuras, Hand of Ragnaros, 0, 80
-Sulfuras, Hand of Ragnaros, -1, 80
-Backstage passes to a TAFKAL80ETC concert, 0, 50
-Backstage passes to a TAFKAL80ETC concert, -5, 0
-Backstage passes to a TAFKAL80ETC concert, -10, 0
-Conjured Mana Cake, -12, 0
-
--------- day 16 --------
-name, sellIn, quality
-+5 Dexterity Vest, -6, 0
-Aged Brie, -14, 30
-Elixir of the Mongoose, -11, 0
-Sulfuras, Hand of Ragnaros, 0, 80
-Sulfuras, Hand of Ragnaros, -1, 80
-Backstage passes to a TAFKAL80ETC concert, -1, 0
-Backstage passes to a TAFKAL80ETC concert, -6, 0
-Backstage passes to a TAFKAL80ETC concert, -11, 0
-Conjured Mana Cake, -13, 0
-
--------- day 17 --------
-name, sellIn, quality
-+5 Dexterity Vest, -7, 0
-Aged Brie, -15, 32
-Elixir of the Mongoose, -12, 0
-Sulfuras, Hand of Ragnaros, 0, 80
-Sulfuras, Hand of Ragnaros, -1, 80
-Backstage passes to a TAFKAL80ETC concert, -2, 0
-Backstage passes to a TAFKAL80ETC concert, -7, 0
-Backstage passes to a TAFKAL80ETC concert, -12, 0
-Conjured Mana Cake, -14, 0
-
--------- day 18 --------
-name, sellIn, quality
-+5 Dexterity Vest, -8, 0
-Aged Brie, -16, 34
-Elixir of the Mongoose, -13, 0
-Sulfuras, Hand of Ragnaros, 0, 80
-Sulfuras, Hand of Ragnaros, -1, 80
-Backstage passes to a TAFKAL80ETC concert, -3, 0
-Backstage passes to a TAFKAL80ETC concert, -8, 0
-Backstage passes to a TAFKAL80ETC concert, -13, 0
-Conjured Mana Cake, -15, 0
-
--------- day 19 --------
-name, sellIn, quality
-+5 Dexterity Vest, -9, 0
-Aged Brie, -17, 36
-Elixir of the Mongoose, -14, 0
-Sulfuras, Hand of Ragnaros, 0, 80
-Sulfuras, Hand of Ragnaros, -1, 80
-Backstage passes to a TAFKAL80ETC concert, -4, 0
-Backstage passes to a TAFKAL80ETC concert, -9, 0
-Backstage passes to a TAFKAL80ETC concert, -14, 0
-Conjured Mana Cake, -16, 0
-
--------- day 20 --------
-name, sellIn, quality
-+5 Dexterity Vest, -10, 0
-Aged Brie, -18, 38
-Elixir of the Mongoose, -15, 0
-Sulfuras, Hand of Ragnaros, 0, 80
-Sulfuras, Hand of Ragnaros, -1, 80
-Backstage passes to a TAFKAL80ETC concert, -5, 0
-Backstage passes to a TAFKAL80ETC concert, -10, 0
-Backstage passes to a TAFKAL80ETC concert, -15, 0
-Conjured Mana Cake, -17, 0
-
--------- day 21 --------
-name, sellIn, quality
-+5 Dexterity Vest, -11, 0
-Aged Brie, -19, 40
-Elixir of the Mongoose, -16, 0
-Sulfuras, Hand of Ragnaros, 0, 80
-Sulfuras, Hand of Ragnaros, -1, 80
-Backstage passes to a TAFKAL80ETC concert, -6, 0
-Backstage passes to a TAFKAL80ETC concert, -11, 0
-Backstage passes to a TAFKAL80ETC concert, -16, 0
-Conjured Mana Cake, -18, 0
-
--------- day 22 --------
-name, sellIn, quality
-+5 Dexterity Vest, -12, 0
-Aged Brie, -20, 42
-Elixir of the Mongoose, -17, 0
-Sulfuras, Hand of Ragnaros, 0, 80
-Sulfuras, Hand of Ragnaros, -1, 80
-Backstage passes to a TAFKAL80ETC concert, -7, 0
-Backstage passes to a TAFKAL80ETC concert, -12, 0
-Backstage passes to a TAFKAL80ETC concert, -17, 0
-Conjured Mana Cake, -19, 0
-
--------- day 23 --------
-name, sellIn, quality
-+5 Dexterity Vest, -13, 0
-Aged Brie, -21, 44
-Elixir of the Mongoose, -18, 0
-Sulfuras, Hand of Ragnaros, 0, 80
-Sulfuras, Hand of Ragnaros, -1, 80
-Backstage passes to a TAFKAL80ETC concert, -8, 0
-Backstage passes to a TAFKAL80ETC concert, -13, 0
-Backstage passes to a TAFKAL80ETC concert, -18, 0
-Conjured Mana Cake, -20, 0
-
--------- day 24 --------
-name, sellIn, quality
-+5 Dexterity Vest, -14, 0
-Aged Brie, -22, 46
-Elixir of the Mongoose, -19, 0
-Sulfuras, Hand of Ragnaros, 0, 80
-Sulfuras, Hand of Ragnaros, -1, 80
-Backstage passes to a TAFKAL80ETC concert, -9, 0
-Backstage passes to a TAFKAL80ETC concert, -14, 0
-Backstage passes to a TAFKAL80ETC concert, -19, 0
-Conjured Mana Cake, -21, 0
-
--------- day 25 --------
-name, sellIn, quality
-+5 Dexterity Vest, -15, 0
-Aged Brie, -23, 48
-Elixir of the Mongoose, -20, 0
-Sulfuras, Hand of Ragnaros, 0, 80
-Sulfuras, Hand of Ragnaros, -1, 80
-Backstage passes to a TAFKAL80ETC concert, -10, 0
-Backstage passes to a TAFKAL80ETC concert, -15, 0
-Backstage passes to a TAFKAL80ETC concert, -20, 0
-Conjured Mana Cake, -22, 0
-
--------- day 26 --------
-name, sellIn, quality
-+5 Dexterity Vest, -16, 0
-Aged Brie, -24, 50
-Elixir of the Mongoose, -21, 0
-Sulfuras, Hand of Ragnaros, 0, 80
-Sulfuras, Hand of Ragnaros, -1, 80
-Backstage passes to a TAFKAL80ETC concert, -11, 0
-Backstage passes to a TAFKAL80ETC concert, -16, 0
-Backstage passes to a TAFKAL80ETC concert, -21, 0
-Conjured Mana Cake, -23, 0
-
--------- day 27 --------
-name, sellIn, quality
-+5 Dexterity Vest, -17, 0
-Aged Brie, -25, 50
-Elixir of the Mongoose, -22, 0
-Sulfuras, Hand of Ragnaros, 0, 80
-Sulfuras, Hand of Ragnaros, -1, 80
-Backstage passes to a TAFKAL80ETC concert, -12, 0
-Backstage passes to a TAFKAL80ETC concert, -17, 0
-Backstage passes to a TAFKAL80ETC concert, -22, 0
-Conjured Mana Cake, -24, 0
-
--------- day 28 --------
-name, sellIn, quality
-+5 Dexterity Vest, -18, 0
-Aged Brie, -26, 50
-Elixir of the Mongoose, -23, 0
-Sulfuras, Hand of Ragnaros, 0, 80
-Sulfuras, Hand of Ragnaros, -1, 80
-Backstage passes to a TAFKAL80ETC concert, -13, 0
-Backstage passes to a TAFKAL80ETC concert, -18, 0
-Backstage passes to a TAFKAL80ETC concert, -23, 0
-Conjured Mana Cake, -25, 0
-
--------- day 29 --------
-name, sellIn, quality
-+5 Dexterity Vest, -19, 0
-Aged Brie, -27, 50
-Elixir of the Mongoose, -24, 0
-Sulfuras, Hand of Ragnaros, 0, 80
-Sulfuras, Hand of Ragnaros, -1, 80
-Backstage passes to a TAFKAL80ETC concert, -14, 0
-Backstage passes to a TAFKAL80ETC concert, -19, 0
-Backstage passes to a TAFKAL80ETC concert, -24, 0
-Conjured Mana Cake, -26, 0
-
--------- day 30 --------
-name, sellIn, quality
-+5 Dexterity Vest, -20, 0
-Aged Brie, -28, 50
-Elixir of the Mongoose, -25, 0
-Sulfuras, Hand of Ragnaros, 0, 80
-Sulfuras, Hand of Ragnaros, -1, 80
-Backstage passes to a TAFKAL80ETC concert, -15, 0
-Backstage passes to a TAFKAL80ETC concert, -20, 0
-Backstage passes to a TAFKAL80ETC concert, -25, 0
-Conjured Mana Cake, -27, 0
-