From 2fb5d2bc779fb6976c16bec1e516b62dba1a513c Mon Sep 17 00:00:00 2001 From: Bjorn Misseghers Date: Tue, 6 Apr 2021 20:21:13 +0200 Subject: [PATCH] Extract quality inc and decrease into private method --- .../main/java/com/gildedrose/GildedRose.java | 20 +++++++++++++------ 1 file changed, 14 insertions(+), 6 deletions(-) diff --git a/Java/src/main/java/com/gildedrose/GildedRose.java b/Java/src/main/java/com/gildedrose/GildedRose.java index 59f8a8d3..16aa1f1f 100644 --- a/Java/src/main/java/com/gildedrose/GildedRose.java +++ b/Java/src/main/java/com/gildedrose/GildedRose.java @@ -20,23 +20,23 @@ class GildedRose { && !currentItem.name.equals(ITEM_BACKSTAGE_PASSES)) { if (currentItem.quality > MIN_QUALITY_LEVEL) { if (!currentItem.name.equals(ITEM_SULFURAS_HAND_OF_RAGNAROS)) { - currentItem.quality = currentItem.quality - 1; + decreaseQuality(currentItem); } } } else { if (currentItem.quality < MAX_QUALITY_LEVEL) { - currentItem.quality = currentItem.quality + 1; + increaseQuality(currentItem); if (currentItem.name.equals(ITEM_BACKSTAGE_PASSES)) { if (currentItem.sellIn < 11) { if (currentItem.quality < MAX_QUALITY_LEVEL) { - currentItem.quality = currentItem.quality + 1; + increaseQuality(currentItem); } } if (currentItem.sellIn < 6) { if (currentItem.quality < MAX_QUALITY_LEVEL) { - currentItem.quality = currentItem.quality + 1; + increaseQuality(currentItem); } } } @@ -52,7 +52,7 @@ class GildedRose { if (!currentItem.name.equals(ITEM_BACKSTAGE_PASSES)) { if (currentItem.quality > MIN_QUALITY_LEVEL) { if (!currentItem.name.equals(ITEM_SULFURAS_HAND_OF_RAGNAROS)) { - currentItem.quality = currentItem.quality - 1; + decreaseQuality(currentItem); } } } else { @@ -60,10 +60,18 @@ class GildedRose { } } else { if (currentItem.quality < MAX_QUALITY_LEVEL) { - currentItem.quality = currentItem.quality + 1; + increaseQuality(currentItem); } } } } } + + private void decreaseQuality(Item item) { + item.quality = item.quality - 1; + } + + private void increaseQuality(Item item) { + item.quality = item.quality + 1; + } } \ No newline at end of file