From 30a03a10d554860b73b1b331c90d79fe3eb48b7f Mon Sep 17 00:00:00 2001 From: Bart Van der Plancken Date: Thu, 6 Feb 2020 21:46:25 +0100 Subject: [PATCH] move quality updates after sell in value updates to quality updates block --- .../main/java/com/gildedrose/GildedRose.java | 25 +++++++++---------- 1 file changed, 12 insertions(+), 13 deletions(-) diff --git a/Java/src/main/java/com/gildedrose/GildedRose.java b/Java/src/main/java/com/gildedrose/GildedRose.java index e5229b06..e99fb013 100644 --- a/Java/src/main/java/com/gildedrose/GildedRose.java +++ b/Java/src/main/java/com/gildedrose/GildedRose.java @@ -23,23 +23,22 @@ class GildedRose { if (isEnhancingItem(item)) { int qualityOffset = determineQualityOffset(item); enhanceItem(item, qualityOffset); + if (item.sellIn <= 0) { + if( item.name.equals(AGED_BRIE)) { + enhanceItem(item, 1); + } else { + degradeItem(item, item.quality); + } + + } } else { degradeItem(item,1); + if(item.sellIn <= 0) { + degradeItem(item, 1); + } } updateSellInValue(item); - - if (item.sellIn < 0) { - if (item.name.equals(AGED_BRIE)) { - enhanceItem(item, 1); - } else { - if (item.name.equals(BACKSTAGE_PASSES)) { - degradeItem(item,item.quality); - } else { - degradeItem(item,1); - } - } - } } } @@ -111,6 +110,6 @@ class GildedRose { * @param item the item of which the sell in value is updated */ private void updateSellInValue(Item item) { - item.sellIn = item.sellIn - 1; + item.sellIn -= 1; } } \ No newline at end of file