OpenSource/GildedRose-Refactoring-Kata
1
0
Fork 0
mirror of https://github.com/emilybache/GildedRose-Refactoring-Kata.git synced 2026-02-16 06:51:27 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Extract the logic into a more OO approach. Without further requirements ellicitation this should be fine

Browse Source
This commit is contained in:
joenelson@maggie 2023-04-04 22:49:48 +01:00
parent 20b9c0d7a2
commit 31ba62bf31
1 changed files with 52 additions and 43 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

95
ruby/gilded_rose.rb
View File

@ -1,4 +1,50 @@
class GildedRose class GildedRose
REGULAR_MAX_QUALITY = 50
REGULAR_MIN_QUALITY = 0
INVENTORY_CLASSIFICATION = {
nil => Proc.new do |sell_in:, quality:|
next_sell_in = sell_in -1
{
sell_in: next_sell_in,
quality: self.regular_quality_limit(
quality + (next_sell_in < 0 ? -2 : -1)
)
}
end,
'Aged Brie' => Proc.new do |sell_in:, quality:|
next_sell_in = sell_in -1
{
sell_in: next_sell_in,
quality: self.regular_quality_limit(
quality + (next_sell_in < 0 ? 2 : 1)
)
}
end,
'Sulfuras, Hand of Ragnaros' => Proc.new do |sell_in:, quality:|
{
sell_in: sell_in,
quality: 80
}
end,
'Backstage passes to a TAFKAL80ETC concert' => Proc.new do |sell_in:, quality:|
next_sell_in = sell_in -1
next_quality = quality + 1
next_quality += 1 if next_sell_in < 10
next_quality += 1 if next_sell_in < 5
next_quality = 0 if next_sell_in < 0
{
sell_in: next_sell_in,
quality: self.regular_quality_limit(next_quality)
}
end,
}
def self.regular_quality_limit(unsanitized_quality)
[
[REGULAR_MIN_QUALITY, unsanitized_quality].max,
REGULAR_MAX_QUALITY
].min
end
def initialize(items) def initialize(items)
@items = items @items = items
@ -6,49 +52,12 @@ class GildedRose
def update_quality() def update_quality()
@items.each do |item| @items.each do |item|
if item.name != "Aged Brie" and item.name != "Backstage passes to a TAFKAL80ETC concert" new_values = (INVENTORY_CLASSIFICATION[item.name] || INVENTORY_CLASSIFICATION[nil]).call(
if item.quality > 0 sell_in: item.sell_in,
if item.name != "Sulfuras, Hand of Ragnaros" quality: item.quality
item.quality = item.quality - 1 )
end item.sell_in = new_values[:sell_in]
end item.quality = new_values[:quality]
else
if item.quality < 50
item.quality = item.quality + 1
if item.name == "Backstage passes to a TAFKAL80ETC concert"
if item.sell_in < 11
if item.quality < 50
item.quality = item.quality + 1
end
end
if item.sell_in < 6
if item.quality < 50
item.quality = item.quality + 1
end
end
end
end
end
if item.name != "Sulfuras, Hand of Ragnaros"
item.sell_in = item.sell_in - 1
end
if item.sell_in < 0
if item.name != "Aged Brie"
if item.name != "Backstage passes to a TAFKAL80ETC concert"
if item.quality > 0
if item.name != "Sulfuras, Hand of Ragnaros"
item.quality = item.quality - 1
end
end
else
item.quality = item.quality - item.quality
end
else
if item.quality < 50
item.quality = item.quality + 1
end
end
end
end end
end end
end end