OpenSource/GildedRose-Refactoring-Kata
1
0
Fork 0
mirror of https://github.com/emilybache/GildedRose-Refactoring-Kata.git synced 2026-02-20 17:01:06 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Refactor updateQuality method implementation by breaking it into specific updates for each item

Browse Source
This commit is contained in:
EmanuelDicu 2022-06-29 12:32:56 +01:00
parent 0cd989a757
commit 31c3d16ad6
1 changed files with 54 additions and 46 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

98
TypeScript/app/gilded-rose.ts
View File

@ -17,53 +17,61 @@ export class GildedRose {
this.items = items; this.items = items;
} }
updateQuality() { private static updateSulfuras(item: Item) {
for (let i = 0; i < this.items.length; i++) { // do nothing
if (this.items[i].name != 'Aged Brie' && this.items[i].name != 'Backstage passes to a TAFKAL80ETC concert') {
if (this.items[i].quality > 0) {
if (this.items[i].name != 'Sulfuras, Hand of Ragnaros') {
this.items[i].quality = this.items[i].quality - 1
}
}
} else {
if (this.items[i].quality < 50) {
this.items[i].quality = this.items[i].quality + 1
if (this.items[i].name == 'Backstage passes to a TAFKAL80ETC concert') {
if (this.items[i].sellIn < 11) {
if (this.items[i].quality < 50) {
this.items[i].quality = this.items[i].quality + 1
}
}
if (this.items[i].sellIn < 6) {
if (this.items[i].quality < 50) {
this.items[i].quality = this.items[i].quality + 1
}
}
}
}
}
if (this.items[i].name != 'Sulfuras, Hand of Ragnaros') {
this.items[i].sellIn = this.items[i].sellIn - 1;
}
if (this.items[i].sellIn < 0) {
if (this.items[i].name != 'Aged Brie') {
if (this.items[i].name != 'Backstage passes to a TAFKAL80ETC concert') {
if (this.items[i].quality > 0) {
if (this.items[i].name != 'Sulfuras, Hand of Ragnaros') {
this.items[i].quality = this.items[i].quality - 1
}
}
} else {
this.items[i].quality = this.items[i].quality - this.items[i].quality
}
} else {
if (this.items[i].quality < 50) {
this.items[i].quality = this.items[i].quality + 1
}
}
}
} }
private static updateBackstagePass(item: Item) {
if (10 <= item.sellIn)
item.quality += 1;
else if (5 <= item.sellIn && item.sellIn < 10)
item.quality += 2;
else if (0 <= item.sellIn && item.sellIn < 5)
item.quality += 3;
else
item.quality = 0;
}
private static updateAgedBrie(item: Item) {
++item.quality;
if (item.sellIn < 0)
++item.quality;
}
private static updateRegularItem(item: Item) {
--item.quality;
if (item.sellIn < 0)
--item.quality;
}
private static reboundQuality(item: Item) {
if (item.quality < 0)
item.quality = 0;
if (item.quality > 50)
item.quality = 50;
}
private updateItemQuality(item: Item) {
--item.sellIn;
switch (item.name) {
case 'Sulfuras, Hand of Ragnaros':
GildedRose.updateSulfuras(item);
break;
case 'Backstage passes to a TAFKAL80ETC concert':
GildedRose.updateBackstagePass(item);
break;
case 'Aged Brie':
GildedRose.updateAgedBrie(item);
break;
default:
GildedRose.updateRegularItem(item);
}
GildedRose.reboundQuality(item);
}
updateQuality() {
for (let i = 0; i < this.items.length; i++)
this.updateItemQuality(this.items[i]);
return this.items; return this.items;
} }
} }