From 379648a572f733edcab8c3c21b608a9eb1e90fb3 Mon Sep 17 00:00:00 2001 From: pierre Date: Sun, 19 Feb 2023 13:29:50 +0100 Subject: [PATCH] feat: adding a updateItem method to keep the code dry --- .../main/java/com/gildedrose/GildedRose.java | 28 +++++++++---------- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/Java/src/main/java/com/gildedrose/GildedRose.java b/Java/src/main/java/com/gildedrose/GildedRose.java index 4d9966d8..37b1f209 100644 --- a/Java/src/main/java/com/gildedrose/GildedRose.java +++ b/Java/src/main/java/com/gildedrose/GildedRose.java @@ -12,13 +12,7 @@ class GildedRose { if (!items[i].name.equals("Aged Brie") && !items[i].name.equals("Backstage passes to a TAFKAL80ETC concert")) { if (items[i].quality > 0) { - if (!items[i].name.equals("Sulfuras, Hand of Ragnaros")) { - items[i].quality = items[i].quality - 1; - - if (items[i].name.equals("Conjured Mana Cake") && items[i].quality > 0) { - items[i].quality = items[i].quality - 1; - } - } + updateItem(items[i]); } } else { if (items[i].quality < 50) { @@ -43,13 +37,7 @@ class GildedRose { if (!items[i].name.equals("Aged Brie")) { if (!items[i].name.equals("Backstage passes to a TAFKAL80ETC concert")) { if (items[i].quality > 0) { - if (!items[i].name.equals("Sulfuras, Hand of Ragnaros")) { - items[i].quality = items[i].quality - 1; - - if (items[i].name.equals("Conjured Mana Cake") && items[i].quality > 0) { - items[i].quality = items[i].quality - 1; - } - } + updateItem(items[i]); } } else { items[i].quality = items[i].quality - items[i].quality; @@ -62,4 +50,16 @@ class GildedRose { } } } + public void updateItem(Item item){ + if (!item.name.equals("Sulfuras, Hand of Ragnaros")) { + item.quality = item.quality - 1; + + if (item.name.equals("Conjured Mana Cake") && item.quality > 0) { + item.quality = item.quality - 1; + } + } + + + } + }