OpenSource/GildedRose-Refactoring-Kata
1
0
Fork 0
mirror of https://github.com/emilybache/GildedRose-Refactoring-Kata.git synced 2026-02-04 09:11:39 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Level 1: Refactoring

Browse Source
This commit is contained in:
Maral 2025-04-03 23:09:26 +02:00
parent b3a0463bba
commit 3a189a071c
2 changed files with 79 additions and 37 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

79
python/gilded_rose.py
View File

@ -7,40 +7,59 @@ class GildedRose(object):
def update_quality(self): def update_quality(self):
for item in self.items: for item in self.items:
if item.name != "Aged Brie" and item.name != "Backstage passes to a TAFKAL80ETC concert": self.update_sell_in(item)
if item.quality > 0: self.update_item_quality(item)
if item.name != "Sulfuras, Hand of Ragnaros":
item.quality = item.quality - 1 def update_sell_in(self, item):
else: if item.name != "Sulfuras, Hand of Ragnaros":
if item.quality < 50: item.days_left -= 1
item.quality = item.quality + 1
if item.name == "Backstage passes to a TAFKAL80ETC concert":
if item.sell_in < 11: def update_item_quality(self,item):
if item.quality < 50: if item.name == "Aged Brie":
item.quality = item.quality + 1 self.update_aged_brie_quality(item)
if item.sell_in < 6: elif item.name == "Backstage passes to a TAFKAL80ETC concert":
if item.quality < 50: self.update_backstage_passes_quality(item)
item.quality = item.quality + 1 elif item.name == "Sulfuras, Hand of Ragnaros":
if item.name != "Sulfuras, Hand of Ragnaros": pass
item.sell_in = item.sell_in - 1 else:
if item.sell_in < 0: self.update_normal_item_quality(item)
if item.name != "Aged Brie":
if item.name != "Backstage passes to a TAFKAL80ETC concert": def update_normal_item_quality(self,item):
if item.quality > 0: if item.quality >0:
if item.name != "Sulfuras, Hand of Ragnaros": item.quality -=1
item.quality = item.quality - 1
else: if item.days_left < 0 and item.quality > 0:
item.quality = item.quality - item.quality item.quality -= 1
else:
if item.quality < 50: def update_aged_brie_quality(self, item):
item.quality = item.quality + 1 if item.quality < 50:
item.quality += 1
if item.days_left < 0 and item.quality < 50:
item.quality += 1
def update_backstage_passes_quality(self, item):
if item.days_left < 0:
item.quality = 0
elif item.days_left < 5:
item.quality += 3
elif item.days_left < 10:
item.quality += 2
else:
item.quality += 1
if item.quality > 50:
item.quality = 50
class Item: class Item:
def __init__(self, name, sell_in, quality): def __init__(self, name, days_left, quality):
self.name = name self.name = name
self.sell_in = sell_in self.days_left = days_left
self.quality = quality self.quality = quality
def __repr__(self): def __repr__(self):
return "%s, %s, %s" % (self.name, self.sell_in, self.quality) return "%s, %s, %s" % (self.name, self.days_left, self.quality)

37
python/test_gilded_rose.py
View File

@ -1,16 +1,39 @@
# -*- coding: utf-8 -*-
import unittest import unittest
from gilded_rose import Item, GildedRose from gilded_rose import Item, GildedRose
class GildedRoseTest(unittest.TestCase): class GildedRoseTest(unittest.TestCase):
def test_foo(self):
items = [Item("foo", 0, 0)]
gilded_rose = GildedRose(items)
gilded_rose.update_quality()
self.assertEqual("fixme", items[0].name)
def test_regular_item(self):
items = [Item("Normal Item", 10, 15)]
gr = GildedRose(items)
gr.update_quality()
self.assertEqual(items[0].days_left, 9) #days decreases
self.assertEqual(items[0].quality, 14) #quality decreases
def test_aged_brie(self):
items = [Item("Aged Brie", 10, 40)]
gr = GildedRose(items)
gr.update_quality()
self.assertEqual(items[0].quality,41) #increases in quality
def test_backstage_passes(self):
items = [Item("Backstage passes to a TAFKAL80ETC concert", 5, 20)]
gr = GildedRose(items)
gr.update_quality()
self.assertEqual(items[0].quality, 23) #increases in quality by 3
def test_sulfuras(self):
items = [Item("Sulfuras, Hand of Ragnaros", 5, 80)]
gr = GildedRose(items)
gr.update_quality()
self.assertEqual(items[0].quality, 80) #stays the same
self.assertEqual(items[0].days_left, 5) #stays the same
if __name__ == '__main__': if __name__ == '__main__':
unittest.main() unittest.main()