OpenSource/GildedRose-Refactoring-Kata
1
0
Fork 0
mirror of https://github.com/emilybache/GildedRose-Refactoring-Kata.git synced 2026-02-04 09:11:39 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

split || if condition

Browse Source
This commit is contained in:
Karim Fadel 2026-01-14 06:55:07 +02:00
parent f0afa8c7d7
commit 3ab5fb11d1
1 changed files with 25 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

37
Java-Approvals/src/main/java/com/gildedrose/GildedRose.java
View File

@ -12,8 +12,21 @@ class GildedRose {
public void updateQuality() { public void updateQuality() {
for (int i = 0; i < items.length; i++) { for (int i = 0; i < items.length; i++) {
if (items[i].name.equals(AGED_BRIE) if (items[i].name.equals(AGED_BRIE)) {
|| items[i].name.equals(BACKSTAGE_PASSES)) { if (items[i].quality < 50) {
items[i].quality = items[i].quality + 1;
if (items[i].name.equals(BACKSTAGE_PASSES)) {
if (items[i].sellIn < 11) {
incrementQualityByOne(i);
}
if (items[i].sellIn < 6) {
incrementQualityByOne(i);
}
}
}
} else if (items[i].name.equals(BACKSTAGE_PASSES)) {
if (items[i].quality < 50) { if (items[i].quality < 50) {
items[i].quality = items[i].quality + 1; items[i].quality = items[i].quality + 1;
@ -28,11 +41,7 @@ class GildedRose {
} }
} }
} else { } else {
if (items[i].quality > 0) { decreaseQualityByOne(i);
if (!items[i].name.equals(SULFURAS)) {
items[i].quality = items[i].quality - 1;
}
}
} }
if (!items[i].name.equals(SULFURAS)) { if (!items[i].name.equals(SULFURAS)) {
@ -46,17 +55,21 @@ class GildedRose {
if (items[i].name.equals(BACKSTAGE_PASSES)) { if (items[i].name.equals(BACKSTAGE_PASSES)) {
items[i].quality = 0; items[i].quality = 0;
} else { } else {
if (items[i].quality > 0) { decreaseQualityByOne(i);
if (!items[i].name.equals(SULFURAS)) {
items[i].quality = items[i].quality - 1;
}
}
} }
} }
} }
} }
} }
private void decreaseQualityByOne(int i) {
if (items[i].quality > 0) {
if (!items[i].name.equals(SULFURAS)) {
items[i].quality = items[i].quality - 1;
}
}
}
private void incrementQualityByOne(int i) { private void incrementQualityByOne(int i) {
if (items[i].quality < 50) { if (items[i].quality < 50) {
items[i].quality = items[i].quality + 1; items[i].quality = items[i].quality + 1;