OpenSource/GildedRose-Refactoring-Kata
1
0
Fork 0
mirror of https://github.com/emilybache/GildedRose-Refactoring-Kata.git synced 2026-02-11 04:31:21 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Refactoring to Improve code

Browse Source
This commit is contained in:
Kunnal-chawla 2025-12-28 10:54:11 +05:30
parent f383a71f3b
commit 409a27fd38
2 changed files with 29 additions and 24 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

BIN
.coverage
View File

Binary file not shown.

53
python/gilded_rose.py
View File

@ -1,11 +1,22 @@
# utf-8 from typing import Final
class Item:
def __init__(self, name, sell_in, quality):
self.name = name
self.sell_in = sell_in
self.quality = quality
def __repr__(self):
return "%s, %s, %s" % (self.name, self.sell_in, self.quality)
class Updater(object): class Updater(object):
MIN_QUALITY = 0 MIN_QUALITY:Final[int] = 0
MAX_QUALITY = 50 MAX_QUALITY: Final[int] = 50
def normal_item(self, item): def normal_item(self, item:Item):
if item.sell_in > 0: if item.sell_in > 0:
depreciation = -1 depreciation = -1
else: else:
@ -13,7 +24,7 @@ class Updater(object):
item.quality = max((item.quality + depreciation), self.MIN_QUALITY) item.quality = max((item.quality + depreciation), self.MIN_QUALITY)
item.sell_in += -1 item.sell_in += -1
def aged_brie(self, item): def aged_brie(self, item:Item):
if item.sell_in > 0: if item.sell_in > 0:
appreciation = 1 appreciation = 1
else: else:
@ -21,10 +32,10 @@ class Updater(object):
item.quality = min((item.quality + appreciation), self.MAX_QUALITY) item.quality = min((item.quality + appreciation), self.MAX_QUALITY)
item.sell_in += -1 item.sell_in += -1
def sulfuras(self, item): def sulfuras(self, item:Item):
pass pass
def backstage_passes(self, item): def backstage_passes(self, item:Item):
def get_quality(item, appreciation): def get_quality(item, appreciation):
item.quality = min(item.quality + appreciation , self.MAX_QUALITY) item.quality = min(item.quality + appreciation , self.MAX_QUALITY)
@ -42,7 +53,7 @@ class Updater(object):
item.quality = 0 item.quality = 0
item.sell_in += -1 item.sell_in += -1
def conjured(self, item): def conjured(self, item:Item):
if item.sell_in > 0: if item.sell_in > 0:
depreciation = -2 depreciation = -2
else: else:
@ -54,31 +65,25 @@ class Updater(object):
class GildedRose(object): class GildedRose(object):
def __init__(self, items): AGED_BRIE: Final[str] = "Aged Brie"
BACKSTAGE_PASSES: Final[str] = "Backstage passes to a TAFKAL80ETC concert"
SULFURAS: Final[str] = "Sulfuras, Hand of Ragnaros"
CONJURED: Final[str] = "Conjured Mana Cake"
def __init__(self, items:Item):
self.items = items self.items = items
def update_quality(self): def update_quality(self):
updater = Updater() updater = Updater()
for item in self.items: for item in self.items:
if item.name == 'Aged Brie': if item.name == self.AGED_BRIE:
updater.aged_brie(item) updater.aged_brie(item)
elif item.name == 'Backstage passes to a TAFKAL80ETC concert': elif item.name == self.BACKSTAGE_PASSES:
updater.backstage_passes(item) updater.backstage_passes(item)
elif item.name == 'Sulfuras, Hand of Ragnaros': elif item.name == self.SULFURAS:
updater.sulfuras(item) updater.sulfuras(item)
elif item.name == 'Conjured Mana Cake': elif item.name == self.CONJURED:
updater.conjured(item) updater.conjured(item)
else: else:
updater.normal_item(item) updater.normal_item(item)
class Item:
def __init__(self, name, sell_in, quality):
self.name = name
self.sell_in = sell_in
self.quality = quality
def __repr__(self):
return "%s, %s, %s" % (self.name, self.sell_in, self.quality)