OpenSource/GildedRose-Refactoring-Kata
1
0
Fork 0
mirror of https://github.com/emilybache/GildedRose-Refactoring-Kata.git synced 2026-02-18 07:51:29 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

flatten ifs and added logic to find the quality decrease rate based on expired date and conjured items

Browse Source
This commit is contained in:
shanmukhanath 2022-06-12 17:01:41 +05:30
parent 83eec772c6
commit 409b96897e
1 changed files with 10 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
python/gilded_rose.py
View File

@ -17,14 +17,15 @@ class GildedRose(object):
def update_item_quality(self, item):
isExpired = item.sell_in < 0
qualityDecrease = -1 if item.name != self.CONJURED else -2
qualityDecrease = self.determine_degrate_quality_rate(item,isExpired)
doesDegradeQaulity = item.name != self.AGED_BRIE and item.name != self.BACKSTAGE_PASSES and item.name != self.SULFURAS
if doesDegradeQaulity:
self.adjust_quality(item, qualityDecrease)
if item.name == self.AGED_BRIE:
self.adjust_quality(item, self.qualityIncrease)
qualityIncrease = 2 if isExpired else 1
self.adjust_quality(item, qualityIncrease)
if item.name == self.BACKSTAGE_PASSES:
self.adjust_quality(item, self.qualityIncrease)
@ -32,18 +33,17 @@ class GildedRose(object):
self.adjust_quality(item, self.qualityIncrease)
if item.sell_in < 6:
self.adjust_quality(item, self.qualityIncrease)
if isExpired:
item.quality = item.quality - item.quality
if item.name != self.SULFURAS:
item.sell_in = item.sell_in - 1
if isExpired:
if doesDegradeQaulity:
self.adjust_quality(item, qualityDecrease)
if item.quality == self.BACKSTAGE_PASSES:
item.quality = item.quality - item.quality
if item.quality == self.AGED_BRIE:
self.adjust_quality(item, self.qualityIncrease)
# Logic to determine the Quality Decrease rate based on Expired date and conjured item
def determine_degrate_quality_rate(self, item, isExpired):
qualityDecrease = -1 if item.name != self.CONJURED else -2
return qualityDecrease * 2 if isExpired else qualityDecrease
# Update the quality item value if the quality value is within the range 0 to 50
def adjust_quality(self, item, quality_increase_decrease):