From 468ff532eafeff2d38c8ba7cd9dc73040088b123 Mon Sep 17 00:00:00 2001 From: kitfbgh Date: Sat, 2 Apr 2022 11:26:24 +0800 Subject: [PATCH] Modify conditional statment --- php/src/GildedRose.php | 36 +++++++++++++++++++----------------- 1 file changed, 19 insertions(+), 17 deletions(-) diff --git a/php/src/GildedRose.php b/php/src/GildedRose.php index 735c0a0e..2f560bb8 100644 --- a/php/src/GildedRose.php +++ b/php/src/GildedRose.php @@ -24,13 +24,7 @@ final class GildedRose public function updateQuality(): void { foreach ($this->items as $item) { - if ($item->name !== 'Aged Brie' and $item->name !== 'Backstage passes to a TAFKAL80ETC concert') { - if ($item->quality > 0) { - if ($item->name !== 'Sulfuras, Hand of Ragnaros') { - $item->quality = $item->quality - 1; - } - } - } else { + if ($item->name === 'Aged Brie' || $item->name === 'Backstage passes to a TAFKAL80ETC concert') { if ($item->quality < 50) { $item->quality = $item->quality + 1; if ($item->name === 'Backstage passes to a TAFKAL80ETC concert') { @@ -46,26 +40,34 @@ final class GildedRose } } } + } else { + if ($item->quality > 0) { + if ($item->name !== 'Sulfuras, Hand of Ragnaros') { + $item->quality = $item->quality - 1; + } + } } - if ($item->name !== 'Sulfuras, Hand of Ragnaros') { + if ($item->name === 'Sulfuras, Hand of Ragnaros') { + } else { $item->sellIn = $item->sellIn - 1; } if ($item->sellIn < 0) { - if ($item->name !== 'Aged Brie') { - if ($item->name !== 'Backstage passes to a TAFKAL80ETC concert') { + if ($item->name === 'Aged Brie') { + if ($item->quality < 50) { + $item->quality = $item->quality + 1; + } + } else { + if ($item->name === 'Backstage passes to a TAFKAL80ETC concert') { + $item->quality = $item->quality - $item->quality; + } else { if ($item->quality > 0) { - if ($item->name !== 'Sulfuras, Hand of Ragnaros') { + if ($item->name === 'Sulfuras, Hand of Ragnaros') { + } else { $item->quality = $item->quality - 1; } } - } else { - $item->quality = $item->quality - $item->quality; - } - } else { - if ($item->quality < 50) { - $item->quality = $item->quality + 1; } } }