From 46f45e2661cd463e6c544635521be60b0718370d Mon Sep 17 00:00:00 2001
From: Sam Burns <sam.burns@upmind.com>
Date: Wed, 24 Jan 2024 14:44:10 +0000
Subject: [PATCH] To provide a place for unit tests, move approval tests and
 change config

---
 php/composer.json                              |  5 +++--
 php/phpunit.xml                                |  7 +++++--
 php/tests/{ => approval}/ApprovalTest.php      |  2 +-
 php/tests/{ => approval}/GildedRoseTest.php    |  0
 .../ApprovalTest.testFoo.approved.txt          |  0
 .../ApprovalTest.testThirtyDays.approved.txt   |  0
 php/tests/phpunit/ExampleTest.php              | 18 ++++++++++++++++++
 7 files changed, 27 insertions(+), 5 deletions(-)
 rename php/tests/{ => approval}/ApprovalTest.php (93%)
 rename php/tests/{ => approval}/GildedRoseTest.php (100%)
 rename php/tests/{ => approval}/approvals/ApprovalTest.testFoo.approved.txt (100%)
 rename php/tests/{ => approval}/approvals/ApprovalTest.testThirtyDays.approved.txt (100%)
 create mode 100644 php/tests/phpunit/ExampleTest.php

diff --git a/php/composer.json b/php/composer.json
index a07c73bf..55e66bc5 100644
--- a/php/composer.json
+++ b/php/composer.json
@@ -21,12 +21,13 @@
     },
     "autoload-dev": {
         "psr-4": {
-            "Tests\\": "tests/",
+            "Tests\\": "tests/approval/",
+            "PhpUnitTests\\": "tests/phpunit/",
             "BehatTests\\": "tests/behat/contexts/"
         }
     },
     "scripts": {
-        "tests": "./vendor/bin/phpunit; ./vendor/bin/behat;",
+        "tests": "./vendor/bin/phpunit --testsuite UnitTests; ./vendor/bin/phpunit --testsuite ApprovalTests; ./vendor/bin/behat;",
         "test-coverage": "phpunit --coverage-html build/coverage",
         "check-cs": "ecs check",
         "fix-cs": "ecs check --fix",
diff --git a/php/phpunit.xml b/php/phpunit.xml
index 03f801e1..78b45a16 100644
--- a/php/phpunit.xml
+++ b/php/phpunit.xml
@@ -6,8 +6,11 @@
     </include>
   </coverage>
   <testsuites>
-    <testsuite name="AllTests">
-      <directory>./tests</directory>
+    <testsuite name="ApprovalTests">
+      <directory>./tests/approval</directory>
+    </testsuite>
+    <testsuite name="UnitTests">
+      <directory>./tests/phpunit</directory>
     </testsuite>
   </testsuites>
 </phpunit>
diff --git a/php/tests/ApprovalTest.php b/php/tests/approval/ApprovalTest.php
similarity index 93%
rename from php/tests/ApprovalTest.php
rename to php/tests/approval/ApprovalTest.php
index 5de922a0..8b107430 100644
--- a/php/tests/ApprovalTest.php
+++ b/php/tests/approval/ApprovalTest.php
@@ -34,7 +34,7 @@ class ApprovalTest extends TestCase
         ob_start();
 
         $argv = ['', '30'];
-        include(__DIR__ . '/../fixtures/texttest_fixture.php');
+        include(__DIR__ . '/../../fixtures/texttest_fixture.php');
 
         $output = ob_get_clean();
 
diff --git a/php/tests/GildedRoseTest.php b/php/tests/approval/GildedRoseTest.php
similarity index 100%
rename from php/tests/GildedRoseTest.php
rename to php/tests/approval/GildedRoseTest.php
diff --git a/php/tests/approvals/ApprovalTest.testFoo.approved.txt b/php/tests/approval/approvals/ApprovalTest.testFoo.approved.txt
similarity index 100%
rename from php/tests/approvals/ApprovalTest.testFoo.approved.txt
rename to php/tests/approval/approvals/ApprovalTest.testFoo.approved.txt
diff --git a/php/tests/approvals/ApprovalTest.testThirtyDays.approved.txt b/php/tests/approval/approvals/ApprovalTest.testThirtyDays.approved.txt
similarity index 100%
rename from php/tests/approvals/ApprovalTest.testThirtyDays.approved.txt
rename to php/tests/approval/approvals/ApprovalTest.testThirtyDays.approved.txt
diff --git a/php/tests/phpunit/ExampleTest.php b/php/tests/phpunit/ExampleTest.php
new file mode 100644
index 00000000..ea7b98a0
--- /dev/null
+++ b/php/tests/phpunit/ExampleTest.php
@@ -0,0 +1,18 @@
+<?php
+
+declare(strict_types=1);
+
+namespace PhpUnitTests;
+
+use ApprovalTests\Approvals;
+use GildedRose\GildedRose;
+use GildedRose\Item;
+use PHPUnit\Framework\TestCase;
+
+class ExamplelTest extends TestCase
+{
+    public function testFoo(): void
+    {
+        $this->assertTrue(true);
+    }
+}