OpenSource/GildedRose-Refactoring-Kata
1
0
Fork 0
mirror of https://github.com/emilybache/GildedRose-Refactoring-Kata.git synced 2026-02-20 00:41:07 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

commented previous code

Browse Source
This commit is contained in:
Arpita Saha 2021-12-23 19:42:03 -05:00
parent 47a41e4a55
commit 475ac1a916
2 changed files with 58 additions and 62 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

118
js-jest/src/gilded_rose.js
View File

@ -9,7 +9,7 @@ class Item {
//This class will hold the rules for the items. making it easier to accomodate future additions to the shop //This class will hold the rules for the items. making it easier to accomodate future additions to the shop
class Rules { class Rules {
constructor(dailyQualityChangeValue, maxQuality, minQuality, tenDayChange, fiveDayChange, constructor(dailyQualityChangeValue, maxQuality, minQuality, tenDayChange, fiveDayChange,
isZeroDayQualityDrop, zeroDayQualityValue, isSellInValueChangeAllowed, isConcert) { isZeroDayQualityDrop, zeroDayQualityValue, isSellInValueChangeAllowed) {
this.dailyQualityChangeValue = dailyQualityChangeValue; this.dailyQualityChangeValue = dailyQualityChangeValue;
this.maxQuality = maxQuality; this.maxQuality = maxQuality;
this.minQuality = minQuality; this.minQuality = minQuality;
@ -18,7 +18,6 @@ class Rules {
this.isZeroDayQualityDrop = isZeroDayQualityDrop; this.isZeroDayQualityDrop = isZeroDayQualityDrop;
this.zeroDayQualityValue = zeroDayQualityValue; this.zeroDayQualityValue = zeroDayQualityValue;
this.isSellInValueChangeAllowed = isSellInValueChangeAllowed; this.isSellInValueChangeAllowed = isSellInValueChangeAllowed;
this.isConcert = isConcert;
} }
} }
@ -28,13 +27,13 @@ class Shop {
} }
updateQualityNew() { updateQuality() {
const rules = { const rules = {
'Aged Brie': new Rules(1, 50, 0, 1, 1, false, 0, true, false), 'Aged Brie': new Rules(1, 50, 0, 1, 1, false, 0, true),
'Backstage passes to a TAFKAL80ETC concert': new Rules(1, 50, 0, 2, 3, true, 0, true, true), 'Backstage passes to a TAFKAL80ETC concert': new Rules(1, 50, 0, 2, 3, true, 0, true),
'Sulfuras, Hand of Ragnaros': new Rules(0, Infinity, 0, 0, 0, false, 0, false, false), 'Sulfuras, Hand of Ragnaros': new Rules(0, Infinity, 0, 0, 0, false, 0, false),
'Conjured Mana Cake': new Rules(-2, 50, 0, -2, -2, false, 0, true, false), 'Conjured Mana Cake': new Rules(-2, 50, 0, -2, -2, false, 0, true),
'DEFAULT': new Rules(-1, 50, 0, -1, -1, false, 0, true, false) 'DEFAULT': new Rules(-1, 50, 0, -1, -1, false, 0, true)
} }
//1. Iterate over the item list //1. Iterate over the item list
for (let i = 0; i < this.items.length; i++) { for (let i = 0; i < this.items.length; i++) {
@ -54,13 +53,10 @@ class Shop {
} }
applyRule(itemObj, ruleObj) { applyRule(itemObj, ruleObj) {
//Decrease the sellin value
if (itemObj.sellIn <= 0 && !ruleObj.isZeroDayQualityDrop) { if (itemObj.sellIn <= 0 && !ruleObj.isZeroDayQualityDrop) {
//if sell in day is less than 0 then add the quality by 2 times dailyChangeValue //if sell in day is less than 0 then add the quality by 2 times dailyChangeValue
//Not applicable for concert tickets //Not applicable for concert tickets aka zero day quality drop items
if (!itemObj.isConcert) { itemObj.quality = itemObj.quality + 2 * ruleObj.dailyQualityChangeValue;
itemObj.quality = itemObj.quality + 2 * ruleObj.dailyQualityChangeValue;
}
} else if (itemObj.sellIn <= 0 && ruleObj.isZeroDayQualityDrop) { } else if (itemObj.sellIn <= 0 && ruleObj.isZeroDayQualityDrop) {
/* /*
if sell in day is 0 and quality drop is required on 0 day if sell in day is 0 and quality drop is required on 0 day
@ -111,55 +107,55 @@ class Shop {
} }
} }
updateQuality() { // updateQuality() {
for (let i = 0; i < this.items.length; i++) { // for (let i = 0; i < this.items.length; i++) {
if (this.items[i].name != 'Aged Brie' && this.items[i].name != 'Backstage passes to a TAFKAL80ETC concert') { // if (this.items[i].name != 'Aged Brie' && this.items[i].name != 'Backstage passes to a TAFKAL80ETC concert') {
if (this.items[i].quality > 0) { // if (this.items[i].quality > 0) {
if (this.items[i].name != 'Sulfuras, Hand of Ragnaros') { // if (this.items[i].name != 'Sulfuras, Hand of Ragnaros') {
this.items[i].quality = this.items[i].quality - 1; // this.items[i].quality = this.items[i].quality - 1;
} // }
} // }
} else { // } else {
if (this.items[i].quality < 50) { // if (this.items[i].quality < 50) {
this.items[i].quality = this.items[i].quality + 1; // this.items[i].quality = this.items[i].quality + 1;
if (this.items[i].name == 'Backstage passes to a TAFKAL80ETC concert') { // if (this.items[i].name == 'Backstage passes to a TAFKAL80ETC concert') {
if (this.items[i].sellIn < 11) { // if (this.items[i].sellIn < 11) {
if (this.items[i].quality < 50) { // if (this.items[i].quality < 50) {
this.items[i].quality = this.items[i].quality + 1; // this.items[i].quality = this.items[i].quality + 1;
} // }
} // }
if (this.items[i].sellIn < 6) { // if (this.items[i].sellIn < 6) {
if (this.items[i].quality < 50) { // if (this.items[i].quality < 50) {
this.items[i].quality = this.items[i].quality + 1; // this.items[i].quality = this.items[i].quality + 1;
} // }
} // }
} // }
} // }
} // }
if (this.items[i].name != 'Sulfuras, Hand of Ragnaros') { // if (this.items[i].name != 'Sulfuras, Hand of Ragnaros') {
this.items[i].sellIn = this.items[i].sellIn - 1; // this.items[i].sellIn = this.items[i].sellIn - 1;
} // }
if (this.items[i].sellIn < 0) { // if (this.items[i].sellIn < 0) {
if (this.items[i].name != 'Aged Brie') { // if (this.items[i].name != 'Aged Brie') {
if (this.items[i].name != 'Backstage passes to a TAFKAL80ETC concert') { // if (this.items[i].name != 'Backstage passes to a TAFKAL80ETC concert') {
if (this.items[i].quality > 0) { // if (this.items[i].quality > 0) {
if (this.items[i].name != 'Sulfuras, Hand of Ragnaros') { // if (this.items[i].name != 'Sulfuras, Hand of Ragnaros') {
this.items[i].quality = this.items[i].quality - 1; // this.items[i].quality = this.items[i].quality - 1;
} // }
} // }
} else { // } else {
this.items[i].quality = this.items[i].quality - this.items[i].quality; // this.items[i].quality = this.items[i].quality - this.items[i].quality;
} // }
} else { // } else {
if (this.items[i].quality < 50) { // if (this.items[i].quality < 50) {
this.items[i].quality = this.items[i].quality + 1; // this.items[i].quality = this.items[i].quality + 1;
} // }
} // }
} // }
} // }
return this.items; // return this.items;
} // }
} }

2
js-jest/test/texttest_fixture.js
View File

@ -23,5 +23,5 @@ for (let day = 0; day < days; day++) {
console.log(`\n-------- day ${day} --------`); console.log(`\n-------- day ${day} --------`);
console.log("name, sellIn, quality"); console.log("name, sellIn, quality");
items.forEach(item => console.log(`${item.name}, ${item.sellIn}, ${item.quality}`)); items.forEach(item => console.log(`${item.name}, ${item.sellIn}, ${item.quality}`));
gildedRose.updateQualityNew(); gildedRose.updateQuality();
} }