From 4919bd0d67755cb2b2c3ce9e6399d7853b5e88f5 Mon Sep 17 00:00:00 2001 From: EmanFateen Date: Sun, 23 Nov 2025 00:17:33 +0200 Subject: [PATCH] chore: re-arrange cases --- php/src/GildedRose.php | 23 +++++++++-------------- 1 file changed, 9 insertions(+), 14 deletions(-) diff --git a/php/src/GildedRose.php b/php/src/GildedRose.php index 7a0e4cae..efc99e3c 100644 --- a/php/src/GildedRose.php +++ b/php/src/GildedRose.php @@ -20,28 +20,23 @@ final class GildedRose foreach ($this->items as $item) { if ($item->name === 'Sulfuras, Hand of Ragnaros') continue; - + + $item->sellIn--; if ($item->name === 'Aged Brie') { $item->quality = min(50, ++$item->quality); } else if ($item->name === 'Backstage passes to a TAFKAL80ETC concert') { - if ($item->sellIn <= 5) { - $updatedQuality = $item->quality + 3; - $item->quality = min(50, $updatedQuality); + if ($item->sellIn < 0) { + $item->quality = 0; + } else if ($item->sellIn <= 5) { + $item->quality = min(50, $item->quality + 3); } else if ($item->sellIn <= 10) { - $updatedQuality = $item->quality + 2; - $item->quality = min(50, $updatedQuality); + $item->quality = min(50, $item->quality + 2); } } else { - $updatedQuality = $item->quality - 2; - $item->quality = max(0, $updatedQuality); + $item->quality = max(0, $item->quality - 2); } - - $item->sellIn--; - - if ($item->sellIn < 0 && $item->name === 'Backstage passes to a TAFKAL80ETC concert') - $item->quality = 0; - } } + }