From 4dd7622f7ad3beb4b774c8c5dcdffdf148e3534e Mon Sep 17 00:00:00 2001 From: Chamoda Ranasinghe Date: Tue, 16 Jan 2024 02:36:57 +0700 Subject: [PATCH] Code fixes fixed else if refractor in 2 places fixed item.quality - item.quality to item.quality = 0 --- TypeScript/app/gilded-rose.ts | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/TypeScript/app/gilded-rose.ts b/TypeScript/app/gilded-rose.ts index d8c18125..fbf57b80 100644 --- a/TypeScript/app/gilded-rose.ts +++ b/TypeScript/app/gilded-rose.ts @@ -30,8 +30,7 @@ export class GildedRose { item.quality = item.quality - 1; } } - } else { - if (item.quality < MAX_ITEM_QUALITY) { + } else if (item.quality < MAX_ITEM_QUALITY) { item.quality = item.quality + 1; if (item.name == ItemNames.BACKSTAGE_PASSES) { if (item.sellIn < 11) { @@ -46,7 +45,6 @@ export class GildedRose { } } } - } if (item.name != ItemNames.SULFURAS) { item.sellIn = item.sellIn - 1; } @@ -59,13 +57,11 @@ export class GildedRose { } } } else { - item.quality = item.quality - item.quality; + item.quality = 0; } - } else { - if (item.quality < MAX_ITEM_QUALITY) { + } else if (item.quality < MAX_ITEM_QUALITY) { item.quality = item.quality + 1; } - } } }