OpenSource/GildedRose-Refactoring-Kata
1
0
Fork 0
mirror of https://github.com/emilybache/GildedRose-Refactoring-Kata.git synced 2026-02-18 07:51:29 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

[重構] 拆分個商品的 function

Browse Source
This commit is contained in:
wengYuting 2022-04-07 18:19:51 +08:00
parent 5b05428942
commit 4e6b0606dd
1 changed files with 48 additions and 53 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

101
js-jest/src/gilded_rose.js
View File

@ -10,68 +10,63 @@ class Shop {
constructor(items = []) { constructor(items = []) {
this.items = items; this.items = items;
} }
/*
反轉負向判定（!）
中斷程式碼簡化判定
整合判定（sellIn 變動提到前面拉齊比對基準）
各商品行為抽成單獨的 function
updateQuality => updateItem？
*/
updateQuality() { updateQuality() {
for (let i = 0; i < this.items.length; i++) { for (let i = 0; i < this.items.length; i++) {
if (this.items[i].name === "Sulfuras, Hand of Ragnaros") continue; const item = this.items[i];
if (item.name === "Sulfuras, Hand of Ragnaros") continue;
this.items[i].sellIn = this.items[i].sellIn - 1; item.sellIn = item.sellIn - 1;
switch (item.name) {
if (this.items[i].name === "Aged Brie") { case "Aged Brie":
if (this.items[i].quality < 50) { this.updateAgedBrie(item);
this.items[i].quality = this.items[i].quality + 1; break;
} case "Backstage passes to a TAFKAL80ETC concert":
this.updateBackstagePasses(item);
if (this.items[i].sellIn < 0) { break;
if (this.items[i].quality < 50) { default:
this.items[i].quality = this.items[i].quality + 1; this.updateTheOthers(item);
} break;
}
continue;
}
if (this.items[i].name === "Backstage passes to a TAFKAL80ETC concert") {
if (this.items[i].quality < 50) {
this.items[i].quality = this.items[i].quality + 1;
if (this.items[i].sellIn < 10 && this.items[i].quality < 50) {
this.items[i].quality = this.items[i].quality + 1;
}
if (this.items[i].sellIn < 5 && this.items[i].quality < 50) {
this.items[i].quality = this.items[i].quality + 1;
}
}
if (this.items[i].sellIn < 0) {
this.items[i].quality = this.items[i].quality - this.items[i].quality;
}
continue;
}
if (this.items[i].quality > 0) {
this.items[i].quality = this.items[i].quality - 1;
if (this.items[i].sellIn < 0) {
if (this.items[i].quality > 0) {
this.items[i].quality = this.items[i].quality - 1;
}
}
continue;
} }
} }
return this.items; return this.items;
} }
updateAgedBrie(item) {
if (item.quality < 50) {
item.quality = item.quality + 1;
if (item.sellIn < 0) {
item.quality = item.quality + 1;
}
}
}
updateBackstagePasses(item) {
if (item.quality < 50) {
item.quality = item.quality + 1;
if (item.sellIn < 10 && item.quality < 50) {
item.quality = item.quality + 1;
}
if (item.sellIn < 5 && item.quality < 50) {
item.quality = item.quality + 1;
}
}
if (item.sellIn < 0) {
item.quality = item.quality - item.quality;
}
}
updateTheOthers(item) {
if (item.quality > 0) {
item.quality = item.quality - 1;
if (item.sellIn < 0) {
item.quality = item.quality - 1;
}
}
}
} }
module.exports = { module.exports = {