OpenSource/GildedRose-Refactoring-Kata
1
0
Fork 0
mirror of https://github.com/emilybache/GildedRose-Refactoring-Kata.git synced 2026-02-15 06:21:29 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

extract hardcoded variables

Browse Source
This commit is contained in:
Sallah Kokaina 2019-11-01 18:06:25 +01:00
parent 8157a26c4b
commit 5369c431b5
2 changed files with 18 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
Java/README.md
View File

@ -22,7 +22,11 @@
-[x] however "Sulfuras" is a legendary item and as such its Quality is 80 and it never alters. -[x] however "Sulfuras" is a legendary item and as such its Quality is 80 and it never alters.
## Technical Issues, with a balanced priority ## Technical Issues, with a balanced priority
-[ ] -[x] item names are hardcoded
-[ ] items are identified by the name in a hardcoded way
-[ ] nested logic
-[ ] Item properties are public
## Refactoring actions ## Refactoring actions
-[x] extract hardcoded variables

21
Java/src/main/java/com/gildedrose/GildedRose.java
View File

@ -3,16 +3,21 @@ package com.gildedrose;
class GildedRose { class GildedRose {
Item[] items; Item[] items;
String BRIE = "Aged Brie";
String BACKSTAGE = "Backstage passes to a TAFKAL80ETC concert";
String SULFURAS = "Sulfuras, Hand of Ragnaros";
public GildedRose(Item[] items) { public GildedRose(Item[] items) {
this.items = items; this.items = items;
} }
public void updateQuality() { public void updateQuality() {
for (int i = 0; i < items.length; i++) { for (int i = 0; i < items.length; i++) {
if (!items[i].name.equals("Aged Brie") if (!items[i].name.equals(BRIE)
&& !items[i].name.equals("Backstage passes to a TAFKAL80ETC concert")) { && !items[i].name.equals(BACKSTAGE)) {
if (items[i].quality > 0) { if (items[i].quality > 0) {
if (!items[i].name.equals("Sulfuras, Hand of Ragnaros")) { if (!items[i].name.equals(SULFURAS)) {
items[i].quality = items[i].quality - 1; items[i].quality = items[i].quality - 1;
} }
} }
@ -20,7 +25,7 @@ class GildedRose {
if (items[i].quality < 50) { if (items[i].quality < 50) {
items[i].quality = items[i].quality + 1; items[i].quality = items[i].quality + 1;
if (items[i].name.equals("Backstage passes to a TAFKAL80ETC concert")) { if (items[i].name.equals(BACKSTAGE)) {
if (items[i].sellIn < 11) { if (items[i].sellIn < 11) {
if (items[i].quality < 50) { if (items[i].quality < 50) {
items[i].quality = items[i].quality + 1; items[i].quality = items[i].quality + 1;
@ -36,15 +41,15 @@ class GildedRose {
} }
} }
if (!items[i].name.equals("Sulfuras, Hand of Ragnaros")) { if (!items[i].name.equals(SULFURAS)) {
items[i].sellIn = items[i].sellIn - 1; items[i].sellIn = items[i].sellIn - 1;
} }
if (items[i].sellIn < 0) { if (items[i].sellIn < 0) {
if (!items[i].name.equals("Aged Brie")) { if (!items[i].name.equals(BRIE)) {
if (!items[i].name.equals("Backstage passes to a TAFKAL80ETC concert")) { if (!items[i].name.equals(BACKSTAGE)) {
if (items[i].quality > 0) { if (items[i].quality > 0) {
if (!items[i].name.equals("Sulfuras, Hand of Ragnaros")) { if (!items[i].name.equals(SULFURAS)) {
items[i].quality = items[i].quality - 1; items[i].quality = items[i].quality - 1;
} }
} }