OpenSource/GildedRose-Refactoring-Kata
1
0
Fork 0
mirror of https://github.com/emilybache/GildedRose-Refactoring-Kata.git synced 2026-02-18 16:01:42 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

chore: cleaning the class GildedRose.java

Browse Source
This commit is contained in:
pierre 2023-02-19 15:30:17 +01:00
parent f6f99c1cef
commit 557ba0eb73
1 changed files with 7 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
Java/src/main/java/com/gildedrose/GildedRose.java
View File

@ -31,21 +31,20 @@ class GildedRose {
} }
} }
} else { } else {
updateNormalAndConjuredItem(items[i]); updateNormalAndConjuredItems(items[i]);
} }
items[i].sellIn = items[i].sellIn - 1; items[i].sellIn = items[i].sellIn - 1;
if (items[i].sellIn < 0) { if (items[i].sellIn < 0) {
if (items[i].name.equals("Aged Brie")) { if (items[i].name.equals("Aged Brie") && items[i].quality < 50) {
if (items[i].quality < 50) {
items[i].quality = items[i].quality + 1; items[i].quality = items[i].quality + 1;
} }
}
if (items[i].name.equals("+5 Dexterity Vest") | items[i].name.equals("Elixir of the Mongoose") | if (items[i].name.equals("+5 Dexterity Vest") || items[i].name.equals("Elixir of the Mongoose") ||
items[i].name.equals("Conjured Mana Cake")) { items[i].name.equals("Conjured Mana Cake")) {
updateNormalAndConjuredItem(items[i]); updateNormalAndConjuredItems(items[i]);
} }
if (items[i].name.equals("Backstage passes to a TAFKAL80ETC concert")) { if (items[i].name.equals("Backstage passes to a TAFKAL80ETC concert")) {
items[i].quality = items[i].quality - items[i].quality; items[i].quality = items[i].quality - items[i].quality;
@ -54,14 +53,13 @@ class GildedRose {
} }
} }
public void updateNormalAndConjuredItem(Item item) { private void updateNormalAndConjuredItems(Item item) {
if (item.quality > 0) { if (item.quality > 0) {
item.quality = item.quality - 1; item.quality = item.quality - 1;
if (item.name.equals("Conjured Mana Cake") && item.quality > 0) { if (item.name.equals("Conjured Mana Cake") && item.quality > 0) {
item.quality = item.quality - 1; item.quality = item.quality - 1;
} }
} }
} }
} }