OpenSource/GildedRose-Refactoring-Kata
1
0
Fork 0
mirror of https://github.com/emilybache/GildedRose-Refactoring-Kata.git synced 2025-12-12 12:22:12 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Merge pull request #6 from codecop/master

Browse Source 
Minor additions to JS and PL/SQL
This commit is contained in:
Emily Bache 2014-07-11 20:19:36 +02:00
commit 5a2fcc6bdd
6 changed files with 109 additions and 30 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

54
js/TexttestFixture.html Normal file
View File

@ -0,0 +1,54 @@
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN" "http://www.w3.org/TR/html4/loose.dtd">
<html>
<head>
<title>Gilded Rose Texttest Fixture</title>
<script type="text/javascript" src="lib/jquery-1.7.1/jquery-1.7.1.js"></script>
<script type="text/javascript" src="src/gilded_rose.js"></script>
<script type="text/javascript">
$( document ).ready(function() {
$('body').append('<p>OMGHAI!</p>');
items.push(new Item('+5 Dexterity Vest', 10, 20));
items.push(new Item('Aged Brie', 2, 0));
items.push(new Item('Elixir of the Mongoose', 5, 7));
items.push(new Item('Sulfuras, Hand of Ragnaros', 0, 80));
items.push(new Item('Sulfuras, Hand of Ragnaros', -1, 80));
items.push(new Item('Backstage passes to a TAFKAL80ETC concert', 15, 20));
items.push(new Item('Backstage passes to a TAFKAL80ETC concert', 10, 49));
items.push(new Item('Backstage passes to a TAFKAL80ETC concert', 5, 49));
// this conjured item does not work properly yet
items.push(new Item('Conjured Mana Cake', 3, 6));
var days = 2;
for (var i = 0; i < days; i++) {
showHeaderFor(i);
showItemsFor(i);
update_quality();
}
function showHeaderFor(day) {
$('body').append('<p>-------- day ' + day + ' --------</p>');
}
function showItemsFor(day) {
$('body').append('<p>name, sellIn, quality</p>');
for (var j = 0; j < items.length; j++) {
var item = items[j];
$('body').append('<p>' + item.name + ', ' + item.sell_in + ', ' + item.quality + '</p>');
}
$('body').append('<br />');
}
});
</script>
</head>
<body>
</body>
</html>

7
js/src/gilded_rose.js
View File

@ -6,13 +6,6 @@ function Item(name, sell_in, quality) {
var items = [] var items = []
items.push(new Item('+5 Dexterity Vest', 10, 20));
items.push(new Item('Aged Brie', 2, 0));
items.push(new Item('Elixir of the Mongoose', 5, 7));
items.push(new Item('Sulfuras, Hand of Ragnaros', 0, 80));
items.push(new Item('Backstage passes to a TAFKAL80ETC concert', 15, 20));
items.push(new Item('Conjured Mana Cake', 3, 6));
function update_quality() { function update_quality() {
for (var i = 0; i < items.length; i++) { for (var i = 0; i < items.length; i++) {
if (items[i].name != 'Aged Brie' && items[i].name != 'Backstage passes to a TAFKAL80ETC concert') { if (items[i].name != 'Aged Brie' && items[i].name != 'Backstage passes to a TAFKAL80ETC concert') {

13
plsql/item.sql
View File

@ -1,5 +1,14 @@
PROMPT Creating Table 'ITEM' PROMPT Creating Table 'ITEM'
DROP TABLE item;
BEGIN
EXECUTE IMMEDIATE 'DROP TABLE item';
EXCEPTION
WHEN OTHERS THEN
IF SQLCODE != -942 THEN
RAISE;
END IF;
END;
CREATE TABLE item CREATE TABLE item
( (
name VARCHAR2(100) NOT NULL, name VARCHAR2(100) NOT NULL,
@ -7,3 +16,5 @@ CREATE TABLE item
quality NUMBER(6) NOT NULL quality NUMBER(6) NOT NULL
); );
/ /
SHOW ERRORS;

37
plsql/item_with_id.sql
View File

@ -1,5 +1,14 @@
PROMPT Creating Table 'ITEM' with auto-increment primary key 'ID' PROMPT Creating Table 'ITEM' with auto-increment primary key 'ID'
DROP TABLE item;
BEGIN
EXECUTE IMMEDIATE 'DROP TABLE item';
EXCEPTION
WHEN OTHERS THEN
IF SQLCODE != -942 THEN
RAISE;
END IF;
END;
CREATE TABLE item CREATE TABLE item
( (
id NUMBER(6) NOT NULL, id NUMBER(6) NOT NULL,
@ -13,19 +22,29 @@ ALTER TABLE item ADD (
CONSTRAINT item_pk PRIMARY KEY (ID)); CONSTRAINT item_pk PRIMARY KEY (ID));
/ /
DROP SEQUENCE item_id_seq; BEGIN
CREATE SEQUENCE item_id_seq EXECUTE IMMEDIATE 'DROP SEQUENCE item_id_seq';
INCREMENT BY 1 EXCEPTION
START WITH 1 WHEN OTHERS THEN
IF SQLCODE != -2289 THEN
RAISE;
END IF;
END;
CREATE SEQUENCE item_id_seq
INCREMENT BY 1
START WITH 1
MAXVALUE 999999 MAXVALUE 999999
MINVALUE 1 MINVALUE 1
NOCYCLE; NOCYCLE;
/ /
CREATE OR REPLACE TRIGGER item_bis_trg CREATE OR REPLACE TRIGGER item_bis_trg
BEFORE INSERT ON item BEFORE INSERT ON item
FOR EACH ROW FOR EACH ROW
BEGIN BEGIN
SELECT item_id_seq.NEXTVAL INTO :new.id FROM dual; SELECT item_id_seq.NEXTVAL INTO :new.id FROM dual;
END; END;
/ /
SHOW ERRORS;

8
plsql/texttest_fixture.sql
View File

@ -1,13 +1,15 @@
SET SERVEROUTPUT ON;
DELETE FROM item; DELETE FROM item;
DECLARE DECLARE
l_days NUMBER(3); l_days NUMBER(3);
CURSOR c_items IS CURSOR c_items IS
SELECT name, sell_in, quality FROM item; SELECT name, sell_in, quality FROM item;
l_item c_items%ROWTYPE; l_item c_items%ROWTYPE;
BEGIN BEGIN
DBMS_OUTPUT.PUT_LINE('OMGHAI!'); DBMS_OUTPUT.PUT_LINE('OMGHAI!');
new_item('+5 Dexterity Vest', 10, 20); new_item('+5 Dexterity Vest', 10, 20);
new_item('Aged Brie', 2, 0); new_item('Aged Brie', 2, 0);
new_item('Elixir of the Mongoose', 5, 7); new_item('Elixir of the Mongoose', 5, 7);
@ -18,7 +20,7 @@ BEGIN
new_item('Backstage passes to a TAFKAL80ETC concert', 5, 49); new_item('Backstage passes to a TAFKAL80ETC concert', 5, 49);
-- this conjured item does not work properly yet ; -- this conjured item does not work properly yet ;
new_item('Conjured Mana Cake', 3, 6); new_item('Conjured Mana Cake', 3, 6);
l_days := 2; l_days := 2;
FOR i IN 0 .. l_days - 1 FOR i IN 0 .. l_days - 1

20
plsql/update_quality.sql
View File

@ -12,10 +12,10 @@ BEGIN
l_name := l_item.name; l_name := l_item.name;
l_sell_in := l_item.sell_in; l_sell_in := l_item.sell_in;
l_quality := l_item.quality; l_quality := l_item.quality;
IF l_name != 'Aged Brie' AND l_name != 'Backstage passes to a TAFKAL80ETC concert' THEN IF l_name <> 'Aged Brie' AND l_name <> 'Backstage passes to a TAFKAL80ETC concert' THEN
IF l_quality > 0 THEN IF l_quality > 0 THEN
IF l_name != 'Sulfuras, Hand of Ragnaros' THEN IF l_name <> 'Sulfuras, Hand of Ragnaros' THEN
l_quality := l_quality - 1; l_quality := l_quality - 1;
END IF; END IF;
END IF; END IF;
@ -36,16 +36,16 @@ BEGIN
END IF; END IF;
END IF; END IF;
END IF; END IF;
IF l_name != 'Sulfuras, Hand of Ragnaros' THEN IF l_name <> 'Sulfuras, Hand of Ragnaros' THEN
l_sell_in := l_sell_in - 1; l_sell_in := l_sell_in - 1;
END IF; END IF;
IF l_sell_in < 0 THEN IF l_sell_in < 0 THEN
IF l_name != 'Aged Brie' THEN IF l_name <> 'Aged Brie' THEN
IF l_name != 'Backstage passes to a TAFKAL80ETC concert' THEN IF l_name <> 'Backstage passes to a TAFKAL80ETC concert' THEN
IF l_quality > 0 THEN IF l_quality > 0 THEN
IF l_name != 'Sulfuras, Hand of Ragnaros' THEN IF l_name <> 'Sulfuras, Hand of Ragnaros' THEN
l_quality := l_quality - 1; l_quality := l_quality - 1;
END IF; END IF;
END IF; END IF;
@ -58,7 +58,7 @@ BEGIN
END IF; END IF;
END IF; END IF;
END IF; END IF;
UPDATE item UPDATE item
SET name = l_name, sell_in = l_sell_in, quality = l_quality WHERE CURRENT OF c_items; SET name = l_name, sell_in = l_sell_in, quality = l_quality WHERE CURRENT OF c_items;
END LOOP; END LOOP;